RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:47:44 +00:00
Code Issues Activity Actions

Kernel: Use an IntrusiveRedBlackTree for kernel regions

Browse source 
We were already using a non-intrusive RedBlackTree, and since the kernel
regions tree is non-owning, this is a trivial conversion that makes a
bunch of the tree operations infallible (by being allocation-free.) :^)
This commit is contained in:
Andreas Kling 2022-01-16 13:10:05 +01:00
parent 66e72ed5e6
commit df34f7b90b
3 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Kernel/Memory/MemoryManager.cpp
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2022, Andreas Kling <kling@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -645,10 +645,10 @@ UNMAP_AFTER_INIT void MemoryManager::initialize(u32 cpu)
Region* MemoryManager::kernel_region_from_vaddr(VirtualAddress vaddr) Region* MemoryManager::kernel_region_from_vaddr(VirtualAddress vaddr)
{ {
SpinlockLocker lock(s_mm_lock); SpinlockLocker lock(s_mm_lock);
auto* region_ptr = MM.m_kernel_regions.find_largest_not_above(vaddr.get()); auto* region = MM.m_kernel_regions.find_largest_not_above(vaddr.get());
if (!region_ptr) if (!region || !region->contains(vaddr))
return nullptr; return nullptr;
return (*region_ptr)->contains(vaddr) ? *region_ptr : nullptr; return region;
} }
Region* MemoryManager::find_user_region_from_vaddr_no_lock(AddressSpace& space, VirtualAddress vaddr) Region* MemoryManager::find_user_region_from_vaddr_no_lock(AddressSpace& space, VirtualAddress vaddr)
@ -1111,7 +1111,7 @@ void MemoryManager::register_kernel_region(Region& region)
{ {
VERIFY(region.is_kernel()); VERIFY(region.is_kernel());
SpinlockLocker lock(s_mm_lock); SpinlockLocker lock(s_mm_lock);
m_kernel_regions.insert(region.vaddr().get(), &region); m_kernel_regions.insert(region.vaddr().get(), region);
} }
void MemoryManager::unregister_kernel_region(Region& region) void MemoryManager::unregister_kernel_region(Region& region)
@ -1132,8 +1132,7 @@ void MemoryManager::dump_kernel_regions()
dbgln("BEGIN{} END{} SIZE{} ACCESS NAME", dbgln("BEGIN{} END{} SIZE{} ACCESS NAME",
addr_padding, addr_padding, addr_padding); addr_padding, addr_padding, addr_padding);
SpinlockLocker lock(s_mm_lock); SpinlockLocker lock(s_mm_lock);
for (auto const* region_ptr : m_kernel_regions) { for (auto const& region : m_kernel_regions) {
auto const& region = *region_ptr;
dbgln("{:p} -- {:p} {:p} {:c}{:c}{:c}{:c}{:c}{:c} {}", dbgln("{:p} -- {:p} {:p} {:c}{:c}{:c}{:c}{:c}{:c} {}",
region.vaddr().get(), region.vaddr().get(),
region.vaddr().offset(region.size() - 1).get(), region.vaddr().offset(region.size() - 1).get(),

5
Kernel/Memory/MemoryManager.h
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2022, Andreas Kling <kling@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -8,6 +8,7 @@
#include <AK/Concepts.h> #include <AK/Concepts.h>
#include <AK/HashTable.h> #include <AK/HashTable.h>
#include <AK/IntrusiveRedBlackTree.h>
#include <AK/NonnullOwnPtrVector.h> #include <AK/NonnullOwnPtrVector.h>
#include <AK/NonnullRefPtrVector.h> #include <AK/NonnullRefPtrVector.h>
#include <Kernel/Forward.h> #include <Kernel/Forward.h>
@ -293,7 +294,7 @@ private:
PhysicalPageEntry* m_physical_page_entries { nullptr }; PhysicalPageEntry* m_physical_page_entries { nullptr };
size_t m_physical_page_entries_count { 0 }; size_t m_physical_page_entries_count { 0 };
RedBlackTree<FlatPtr, Region*> m_kernel_regions; IntrusiveRedBlackTree<&Region::m_tree_node> m_kernel_regions;
Vector<UsedMemoryRange> m_used_memory_ranges; Vector<UsedMemoryRange> m_used_memory_ranges;
Vector<PhysicalMemoryRange> m_physical_memory_ranges; Vector<PhysicalMemoryRange> m_physical_memory_ranges;

7
Kernel/Memory/Region.h
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2022, Andreas Kling <kling@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -8,6 +8,7 @@
#include <AK/EnumBits.h> #include <AK/EnumBits.h>
#include <AK/IntrusiveList.h> #include <AK/IntrusiveList.h>
#include <AK/IntrusiveRedBlackTree.h>
#include <AK/Weakable.h> #include <AK/Weakable.h>
#include <Kernel/Forward.h> #include <Kernel/Forward.h>
#include <Kernel/KString.h> #include <Kernel/KString.h>
@ -219,11 +220,11 @@ private:
bool m_stack : 1 { false }; bool m_stack : 1 { false };
bool m_mmap : 1 { false }; bool m_mmap : 1 { false };
bool m_syscall_region : 1 { false }; bool m_syscall_region : 1 { false };
IntrusiveListNode<Region> m_memory_manager_list_node;
IntrusiveRedBlackTreeNode<FlatPtr, Region, RawPtr<Region>> m_tree_node;
IntrusiveListNode<Region> m_vmobject_list_node; IntrusiveListNode<Region> m_vmobject_list_node;
public: public:
using ListInMemoryManager = IntrusiveList<&Region::m_memory_manager_list_node>;
using ListInVMObject = IntrusiveList<&Region::m_vmobject_list_node>; using ListInVMObject = IntrusiveList<&Region::m_vmobject_list_node>;
}; };