RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:37:43 +00:00
Code Issues Activity Actions

LibWeb: Add & use 'HTTP tab or space' from '2.2. HTTP' in the Fetch spec

Browse source
This commit is contained in:
Linus Groh 2022-07-11 22:11:03 +01:00
parent 7c2c9b6859
commit df3e25f1bb
2 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/Fetch/Infrastructure/HTTP.h Normal file
View file

@ -0,0 +1,18 @@
/*
* Copyright (c) 2022, Linus Groh <linusg@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/Forward.h>
#include <AK/StringView.h>
namespace Web::Fetch {
// https://fetch.spec.whatwg.org/#http-tab-or-space
// An HTTP tab or space is U+0009 TAB or U+0020 SPACE.
inline constexpr StringView HTTP_TAB_OR_SPACE = "\t "sv;
}

5
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -24,6 +24,7 @@
#include <LibWeb/DOM/ExceptionOr.h> #include <LibWeb/DOM/ExceptionOr.h>
#include <LibWeb/DOM/IDLEventListener.h> #include <LibWeb/DOM/IDLEventListener.h>
#include <LibWeb/Fetch/AbstractOperations.h> #include <LibWeb/Fetch/AbstractOperations.h>
#include <LibWeb/Fetch/Infrastructure/HTTP.h>
#include <LibWeb/HTML/EventHandler.h> #include <LibWeb/HTML/EventHandler.h>
#include <LibWeb/HTML/EventNames.h> #include <LibWeb/HTML/EventNames.h>
#include <LibWeb/HTML/Origin.h> #include <LibWeb/HTML/Origin.h>
@ -298,9 +299,7 @@ Optional<Vector<String>> XMLHttpRequest::get_decode_and_split(String const& head
} }
// 3. Remove all HTTP tab or space from the start and end of value. // 3. Remove all HTTP tab or space from the start and end of value.
// https://fetch.spec.whatwg.org/#http-tab-or-space auto trimmed_value = value.to_string().trim(Fetch::HTTP_TAB_OR_SPACE, TrimMode::Both);
// An HTTP tab or space is U+0009 TAB or U+0020 SPACE.
auto trimmed_value = value.to_string().trim("\t "sv, TrimMode::Both);
// 4. Append value to values. // 4. Append value to values.
values.append(move(trimmed_value)); values.append(move(trimmed_value));