RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:47:45 +00:00
Code Issues Activity Actions

LibWeb: Implement replacing the current body when setting document.body

Browse source 
Also adds an exception check to the append at the end.
This commit is contained in:
Luke 2021-05-07 00:54:20 +01:00 • committed by Andreas Kling
parent b6004a4ce1
commit df52040ce9
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -222,7 +222,9 @@ ExceptionOr<void> Document::set_body(HTML::HTMLElement& new_body)
auto* existing_body = body();
if (existing_body) {
TODO();
auto replace_result = existing_body->parent()->replace_child(new_body, *existing_body);
if (replace_result.is_exception())
return NonnullRefPtr<DOMException>(replace_result.exception());
return {};
}
@ -230,7 +232,9 @@ ExceptionOr<void> Document::set_body(HTML::HTMLElement& new_body)
if (!document_element)
return DOM::HierarchyRequestError::create("Missing document element");
document_element->append_child(new_body);
auto append_result = document_element->append_child(new_body);
if (append_result.is_exception())
return NonnullRefPtr<DOMException>(append_result.exception());
return {};
}