RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:48:12 +00:00
Code Issues Activity Actions

TextEditor: Fix commenting shortcut <Ctrl-/>

Browse source 
When you select a text area in "bottom-up" way (e.g. from line 10
to line 5), then type the shortcut, the text editor will not
comment those text for you.

Normalize the text range can easily fix this minor bug.
This commit is contained in:
Snow 2022-12-01 19:47:59 +08:00 • committed by Andreas Kling
parent b0af53749d
commit df7c0eacd4
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/TextEditor.cpp
View file

@ -1022,7 +1022,7 @@ void TextEditor::keydown_event(KeyEvent& event)
if (m_highlighter != nullptr) {
auto prefix = m_highlighter->comment_prefix().value_or(""sv);
auto suffix = m_highlighter->comment_suffix().value_or(""sv);
auto range = has_selection() ? selection() : TextRange { { m_cursor.line(), m_cursor.column() }, { m_cursor.line(), m_cursor.column() } };
auto range = has_selection() ? selection().normalized() : TextRange { { m_cursor.line(), m_cursor.column() }, { m_cursor.line(), m_cursor.column() } };
auto is_already_commented = true;
for (size_t i = range.start().line(); i <= range.end().line(); i++) {