RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:28:13 +00:00
Code Issues Activity Actions

LibCompress: Make DeflateCompressor::write() use loop, not recursion

Browse source 
This is performance-neutral, but Instruments.app had a hard time
visualizing the very deeply nested stack frames here.

No behavior change.
This commit is contained in:
Nico Weber 2023-03-12 20:14:56 -04:00 • committed by Brian Gianforcaro
parent e26aebca4f
commit dfb45705e6
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibCompress/Deflate.cpp
View file

@ -477,16 +477,18 @@ ErrorOr<size_t> DeflateCompressor::write(ReadonlyBytes bytes)
{
VERIFY(!m_finished);
if (bytes.size() == 0)
return 0; // recursion base case
size_t total_written = 0;
while (!bytes.is_empty()) {
auto n_written = bytes.copy_trimmed_to(pending_block().slice(m_pending_block_size));
m_pending_block_size += n_written;
auto n_written = bytes.copy_trimmed_to(pending_block().slice(m_pending_block_size));
m_pending_block_size += n_written;
if (m_pending_block_size == block_size)
TRY(flush());
if (m_pending_block_size == block_size)
TRY(flush());
return n_written + TRY(write(bytes.slice(n_written)));
bytes = bytes.slice(n_written);
total_written += n_written;
}
return total_written;
}
bool DeflateCompressor::is_eof() const