RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:27:35 +00:00
Code Issues Activity Actions

LibCore: Prevent duplicate ArgsParser option names

Browse source 
Inspired by #20641, detect when adding an option that its long and short
names are both unique. If they are not, print a warning and crash.
This commit is contained in:
Sam Atkins 2023-08-19 11:56:32 +01:00 • committed by Andreas Kling
parent 2d31903e07
commit dfb5ba0e2c
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibCore/ArgsParser.cpp
View file

@ -388,6 +388,18 @@ void ArgsParser::print_version(FILE* file)
void ArgsParser::add_option(Option&& option) void ArgsParser::add_option(Option&& option)
{ {
for (auto const& existing_option : m_options) {
if (option.long_name && existing_option.long_name == option.long_name) {
warnln("Error: Multiple options have the long name \"--{}\"", option.long_name);
dbgln("Error: Multiple options have the long name \"--{}\"", option.long_name);
VERIFY_NOT_REACHED();
}
if (option.short_name && existing_option.short_name == option.short_name) {
warnln("Error: Multiple options have the short name \"-{}\"", option.short_name);
dbgln("Error: Multiple options have the short name \"-{}\"", option.short_name);
VERIFY_NOT_REACHED();
}
}
m_options.append(move(option)); m_options.append(move(option));
} }