RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:57:44 +00:00
Code Issues Activity Actions

Tests/LibWeb: Move LibWeb test frames to their own directory

Browse source 
We currently have a handful of iframe tests whose sources are in the
"input" directory. This means they get run as their own tests, when they
are really just helper files. We've had to add empty test expectation
files for these "tests", and invoke a dummy test() method just to keep
the test runner happy.

Instead, move them to their own directory so the test runner does not
see them at all.
This commit is contained in:
Timothy Flynn 2024-02-19 15:12:04 -05:00 • committed by Tim Flynn
parent f77e91e0f0
commit e030193e5f
14 changed files with 30 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Tests/LibWeb/Text/input/navigation/history-pushstate-iframe.html
View file

@ -1,20 +0,0 @@
<script src="../include.js"></script>
<script>
try {
const initialHistoryLength = window.history.length;
history.pushState({}, "hello", "history-pushstate-iframe.html#hello");
if (window.self !== window.top) {
parent.postMessage(
"history object length has changed by " +
(window.history.length - initialHistoryLength),
"*"
);
} else {
test(() => {});
}
} catch (e) {
if (window.self !== window.top) parent.postMessage("ERROR:" + e, "*");
}
</script>

4
Tests/LibWeb/Text/input/navigation/history-pushstate.html
View file

@ -18,6 +18,6 @@
done();
});
await navigateIframe("./history-pushstate-iframe.html");
});
await navigateIframe("../../data/history-pushstate-iframe.html");
});
</script>

4
Tests/LibWeb/Text/input/navigation/iframe-navigate-src.html
View file

@ -21,8 +21,8 @@
}
});
await navigateIframe("iframe-test-content-1.html");
await navigateIframe("iframe-test-content-2.html");
await navigateIframe("../../data/iframe-test-content-1.html");
await navigateIframe("../../data/iframe-test-content-2.html");
});
</script>
<iframe id="testIframe" src="about:blank"></iframe>

8
Tests/LibWeb/Text/input/navigation/iframe-test-content-1.html
View file

@ -1,8 +0,0 @@
<script src="../include.js"></script>
<script>
if (window.self !== window.top) {
parent.postMessage("message from test iframe (1)", "*");
} else {
test(() => {});
}
</script>

8
Tests/LibWeb/Text/input/navigation/iframe-test-content-2.html
View file

@ -1,8 +0,0 @@
<script src="../include.js"></script>
<script>
if (window.self !== window.top) {
parent.postMessage("message from test iframe (2)", "*");
} else {
test(() => {});
}
</script>

83
Tests/LibWeb/Text/input/navigation/navigation-navigate-iframe.html
View file

@ -1,83 +0,0 @@
<script src="../include.js"></script>
<script>
function filename(path) {
url = new URL(path)
return url.pathname.split('/').pop() + url.hash
}
asyncTest(async done => {
if (window.self === window.top) {
test(() => {});
return;
}
try {
parent.postMessage(`Initial history length is ${navigation.entries().length}`, "*");
navigation.oncurrententrychange = (e) => {
parent.postMessage(`${e.type} for change to ${filename(navigation.currentEntry.url)} of type ${e.navigationType} from ${filename(e.from.url)}`, "*");
}
navigation.onnavigate = (e) => {
parent.postMessage(`NavigateEvent for ${e.navigationType} ${filename(e.destination.url)} (Same document? ${e.destination.sameDocument}) with info: ${e.info}`, "*")
}
// Navigate to fragment
let a = navigation.navigate("navigation-navigate-iframe.html#1", { info: 42, history: "push" });
await a.committed.then((f) => {
parent.postMessage(`Committed to navigation to ${filename(f.url)}`, "*");
},
(e) => {
parent.postMessage("ERROR:" + e, "*", "*");
})
await a.finished.then((f) => {
parent.postMessage(`Finished navigation to ${filename(f.url)}`, "*");
},
(e) => {
parent.postMessage("ERROR:" + e, "*");
})
parent.postMessage(`History length after navigate is ${navigation.entries().length}`, "*");
// FIXME: Enable these tests 😅
// Navigate backwards
// let b = navigation.back()
// await b.committed.then((f) => {
// parent.postMessage(`Committed to back navigation to ${filename(f.url)}`, "*");
// },
// (e) => {
// parent.postMessage("ERROR:" + e, "*", "*");
// })
// await b.finished.then((f) => {
// parent.postMessage(`Finished back navigation to ${filename(f.url)}`, "*");
// },
// (e) => {
// parent.postMessage("ERROR:" + e, "*");
// })
// parent.postMessage(`History length after back is ${navigation.entries().length}`, "*");
// Navigate forwards
// let c = navigation.forward()
// await c.committed.then((f) => {
// parent.postMessage(`Committed to forward navigation to ${filename(f.url)}`, "*");
// },
// (e) => {
// parent.postMessage("ERROR:" + e, "*", "*");
// })
// await c.finished.then((f) => {
// parent.postMessage(`Finished forward navigation to ${filename(f.url)}`, "*");
// },
// (e) => {
// parent.postMessage("ERROR:" + e, "*");
// })
// parent.postMessage(`History length after forward is ${navigation.entries().length}`, "*");
} catch (e) {
parent.postMessage("ERROR:" + e, "*");
}
parent.postMessage("DONE", "*");
});
</script>

4
Tests/LibWeb/Text/input/navigation/navigation-navigate.html
View file

@ -19,6 +19,6 @@
done();
});
await navigateIframe("./navigation-navigate-iframe.html");
});
await navigateIframe("../../data/navigation-navigate-iframe.html");
});
</script>