From e050f21f36103b2395d655ec5f881d0caff1a4ef Mon Sep 17 00:00:00 2001
From: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
Date: Tue, 11 Aug 2020 00:07:16 +0200
Subject: [PATCH] LibWeb: Mark compilation-unit-only functions as static

This enables a nice warning in case a function becomes dead code. Also, in the
case of {Event,Node}WrapperFactory.cpp, the corresponding header was forgotten.
This would cause an issue later when we enable -Wmissing-declarations.

Is my clang-format misconfigured? Why is the diff for NodeWrapperFactory.cpp
so large?
---
 .../LibWeb/Bindings/EventWrapperFactory.cpp   |  1 +
 .../LibWeb/Bindings/NodeWrapperFactory.cpp    | 30 +++++++++----------
 Libraries/LibWeb/CSS/SelectorEngine.cpp       |  4 +--
 .../CodeGenerators/WrapperGenerator.cpp       |  3 +-
 Libraries/LibWeb/Loader/Resource.cpp          |  4 +--
 5 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/Libraries/LibWeb/Bindings/EventWrapperFactory.cpp b/Libraries/LibWeb/Bindings/EventWrapperFactory.cpp
index 88f4d900fb..46d99f4fd5 100644
--- a/Libraries/LibWeb/Bindings/EventWrapperFactory.cpp
+++ b/Libraries/LibWeb/Bindings/EventWrapperFactory.cpp
@@ -25,6 +25,7 @@
  */
 
 #include <LibWeb/Bindings/EventWrapper.h>
+#include <LibWeb/Bindings/EventWrapperFactory.h>
 #include <LibWeb/Bindings/MouseEventWrapper.h>
 
 namespace Web {
diff --git a/Libraries/LibWeb/Bindings/NodeWrapperFactory.cpp b/Libraries/LibWeb/Bindings/NodeWrapperFactory.cpp
index 4826e02d92..499c36177e 100644
--- a/Libraries/LibWeb/Bindings/NodeWrapperFactory.cpp
+++ b/Libraries/LibWeb/Bindings/NodeWrapperFactory.cpp
@@ -31,33 +31,33 @@
 #include <LibWeb/Bindings/HTMLAnchorElementWrapper.h>
 #include <LibWeb/Bindings/HTMLAreaElementWrapper.h>
 #include <LibWeb/Bindings/HTMLAudioElementWrapper.h>
+#include <LibWeb/Bindings/HTMLBRElementWrapper.h>
 #include <LibWeb/Bindings/HTMLBaseElementWrapper.h>
 #include <LibWeb/Bindings/HTMLBodyElementWrapper.h>
-#include <LibWeb/Bindings/HTMLBRElementWrapper.h>
 #include <LibWeb/Bindings/HTMLButtonElementWrapper.h>
 #include <LibWeb/Bindings/HTMLCanvasElementWrapper.h>
+#include <LibWeb/Bindings/HTMLDListElementWrapper.h>
 #include <LibWeb/Bindings/HTMLDataElementWrapper.h>
-#include <LibWeb/Bindings/HTMLDetailsElementWrapper.h>
 #include <LibWeb/Bindings/HTMLDataListElementWrapper.h>
+#include <LibWeb/Bindings/HTMLDetailsElementWrapper.h>
 #include <LibWeb/Bindings/HTMLDialogElementWrapper.h>
 #include <LibWeb/Bindings/HTMLDivElementWrapper.h>
-#include <LibWeb/Bindings/HTMLDListElementWrapper.h>
+#include <LibWeb/Bindings/HTMLElementWrapper.h>
 #include <LibWeb/Bindings/HTMLEmbedElementWrapper.h>
 #include <LibWeb/Bindings/HTMLFieldSetElementWrapper.h>
-#include <LibWeb/Bindings/HTMLElementWrapper.h>
 #include <LibWeb/Bindings/HTMLFormElementWrapper.h>
 #include <LibWeb/Bindings/HTMLFrameElementWrapper.h>
 #include <LibWeb/Bindings/HTMLFrameSetElementWrapper.h>
+#include <LibWeb/Bindings/HTMLHRElementWrapper.h>
 #include <LibWeb/Bindings/HTMLHeadElementWrapper.h>
 #include <LibWeb/Bindings/HTMLHeadingElementWrapper.h>
-#include <LibWeb/Bindings/HTMLHRElementWrapper.h>
 #include <LibWeb/Bindings/HTMLHtmlElementWrapper.h>
 #include <LibWeb/Bindings/HTMLIFrameElementWrapper.h>
 #include <LibWeb/Bindings/HTMLImageElementWrapper.h>
 #include <LibWeb/Bindings/HTMLInputElementWrapper.h>
+#include <LibWeb/Bindings/HTMLLIElementWrapper.h>
 #include <LibWeb/Bindings/HTMLLabelElementWrapper.h>
 #include <LibWeb/Bindings/HTMLLegendElementWrapper.h>
-#include <LibWeb/Bindings/HTMLLIElementWrapper.h>
 #include <LibWeb/Bindings/HTMLLinkElementWrapper.h>
 #include <LibWeb/Bindings/HTMLMapElementWrapper.h>
 #include <LibWeb/Bindings/HTMLMarqueeElementWrapper.h>
@@ -65,8 +65,8 @@
 #include <LibWeb/Bindings/HTMLMetaElementWrapper.h>
 #include <LibWeb/Bindings/HTMLMeterElementWrapper.h>
 #include <LibWeb/Bindings/HTMLModElementWrapper.h>
-#include <LibWeb/Bindings/HTMLObjectElementWrapper.h>
 #include <LibWeb/Bindings/HTMLOListElementWrapper.h>
+#include <LibWeb/Bindings/HTMLObjectElementWrapper.h>
 #include <LibWeb/Bindings/HTMLOptGroupElementWrapper.h>
 #include <LibWeb/Bindings/HTMLOptionElementWrapper.h>
 #include <LibWeb/Bindings/HTMLOutputElementWrapper.h>
@@ -83,8 +83,8 @@
 #include <LibWeb/Bindings/HTMLSpanElementWrapper.h>
 #include <LibWeb/Bindings/HTMLStyleElementWrapper.h>
 #include <LibWeb/Bindings/HTMLTableCaptionElementWrapper.h>
-#include <LibWeb/Bindings/HTMLTableColElementWrapper.h>
 #include <LibWeb/Bindings/HTMLTableCellElementWrapper.h>
+#include <LibWeb/Bindings/HTMLTableColElementWrapper.h>
 #include <LibWeb/Bindings/HTMLTableElementWrapper.h>
 #include <LibWeb/Bindings/HTMLTableRowElementWrapper.h>
 #include <LibWeb/Bindings/HTMLTableSectionElementWrapper.h>
@@ -97,38 +97,39 @@
 #include <LibWeb/Bindings/HTMLUnknownElementWrapper.h>
 #include <LibWeb/Bindings/HTMLVideoElementWrapper.h>
 #include <LibWeb/Bindings/NodeWrapper.h>
+#include <LibWeb/Bindings/NodeWrapperFactory.h>
 #include <LibWeb/Bindings/TextWrapper.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOM/Node.h>
 #include <LibWeb/HTML/HTMLAnchorElement.h>
 #include <LibWeb/HTML/HTMLAreaElement.h>
 #include <LibWeb/HTML/HTMLAudioElement.h>
+#include <LibWeb/HTML/HTMLBRElement.h>
 #include <LibWeb/HTML/HTMLBaseElement.h>
 #include <LibWeb/HTML/HTMLBodyElement.h>
-#include <LibWeb/HTML/HTMLBRElement.h>
 #include <LibWeb/HTML/HTMLButtonElement.h>
 #include <LibWeb/HTML/HTMLCanvasElement.h>
+#include <LibWeb/HTML/HTMLDListElement.h>
 #include <LibWeb/HTML/HTMLDataElement.h>
-#include <LibWeb/HTML/HTMLDetailsElement.h>
 #include <LibWeb/HTML/HTMLDataListElement.h>
+#include <LibWeb/HTML/HTMLDetailsElement.h>
 #include <LibWeb/HTML/HTMLDialogElement.h>
 #include <LibWeb/HTML/HTMLDivElement.h>
-#include <LibWeb/HTML/HTMLDListElement.h>
 #include <LibWeb/HTML/HTMLEmbedElement.h>
 #include <LibWeb/HTML/HTMLFieldSetElement.h>
 #include <LibWeb/HTML/HTMLFormElement.h>
 #include <LibWeb/HTML/HTMLFrameElement.h>
 #include <LibWeb/HTML/HTMLFrameSetElement.h>
+#include <LibWeb/HTML/HTMLHRElement.h>
 #include <LibWeb/HTML/HTMLHeadElement.h>
 #include <LibWeb/HTML/HTMLHeadingElement.h>
-#include <LibWeb/HTML/HTMLHRElement.h>
 #include <LibWeb/HTML/HTMLHtmlElement.h>
 #include <LibWeb/HTML/HTMLIFrameElement.h>
 #include <LibWeb/HTML/HTMLImageElement.h>
 #include <LibWeb/HTML/HTMLInputElement.h>
+#include <LibWeb/HTML/HTMLLIElement.h>
 #include <LibWeb/HTML/HTMLLabelElement.h>
 #include <LibWeb/HTML/HTMLLegendElement.h>
-#include <LibWeb/HTML/HTMLLIElement.h>
 #include <LibWeb/HTML/HTMLLinkElement.h>
 #include <LibWeb/HTML/HTMLMapElement.h>
 #include <LibWeb/HTML/HTMLMarqueeElement.h>
@@ -136,8 +137,8 @@
 #include <LibWeb/HTML/HTMLMetaElement.h>
 #include <LibWeb/HTML/HTMLMeterElement.h>
 #include <LibWeb/HTML/HTMLModElement.h>
-#include <LibWeb/HTML/HTMLObjectElement.h>
 #include <LibWeb/HTML/HTMLOListElement.h>
+#include <LibWeb/HTML/HTMLObjectElement.h>
 #include <LibWeb/HTML/HTMLOptGroupElement.h>
 #include <LibWeb/HTML/HTMLOptionElement.h>
 #include <LibWeb/HTML/HTMLOutputElement.h>
@@ -167,7 +168,6 @@
 #include <LibWeb/HTML/HTMLUListElement.h>
 #include <LibWeb/HTML/HTMLUnknownElement.h>
 #include <LibWeb/HTML/HTMLVideoElement.h>
-#include <LibWeb/DOM/Node.h>
 
 namespace Web::Bindings {
 
diff --git a/Libraries/LibWeb/CSS/SelectorEngine.cpp b/Libraries/LibWeb/CSS/SelectorEngine.cpp
index d640c5bc54..942fccf0cd 100644
--- a/Libraries/LibWeb/CSS/SelectorEngine.cpp
+++ b/Libraries/LibWeb/CSS/SelectorEngine.cpp
@@ -42,7 +42,7 @@ static bool matches_hover_pseudo_class(const DOM::Element& element)
     return element.is_ancestor_of(*hovered_node);
 }
 
-bool matches(const CSS::Selector::SimpleSelector& component, const DOM::Element& element)
+static bool matches(const CSS::Selector::SimpleSelector& component, const DOM::Element& element)
 {
     switch (component.pseudo_class) {
     case CSS::Selector::SimpleSelector::PseudoClass::None:
@@ -114,7 +114,7 @@ bool matches(const CSS::Selector::SimpleSelector& component, const DOM::Element&
     }
 }
 
-bool matches(const CSS::Selector& selector, int component_list_index, const DOM::Element& element)
+static bool matches(const CSS::Selector& selector, int component_list_index, const DOM::Element& element)
 {
     auto& component_list = selector.complex_selectors()[component_list_index];
     for (auto& component : component_list.compound_selector) {
diff --git a/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp b/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
index 5670104a8c..8472ab3dd7 100644
--- a/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
+++ b/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
@@ -116,7 +116,7 @@ struct Interface {
     String fully_qualified_name;
 };
 
-OwnPtr<Interface> parse_interface(const StringView& input)
+static OwnPtr<Interface> parse_interface(const StringView& input)
 {
     auto interface = make<Interface>();
 
@@ -339,7 +339,6 @@ int main(int argc, char** argv)
         interface->fully_qualified_name = interface->name;
     }
 
-
 #if 0
     dbg() << "Attributes:";
     for (auto& attribute : interface->attributes) {
diff --git a/Libraries/LibWeb/Loader/Resource.cpp b/Libraries/LibWeb/Loader/Resource.cpp
index 418b8d170a..696229dc76 100644
--- a/Libraries/LibWeb/Loader/Resource.cpp
+++ b/Libraries/LibWeb/Loader/Resource.cpp
@@ -60,7 +60,7 @@ void Resource::for_each_client(Function<void(ResourceClient&)> callback)
     }
 }
 
-String encoding_from_content_type(const String& content_type)
+static String encoding_from_content_type(const String& content_type)
 {
     auto offset = content_type.index_of("charset=");
     if (offset.has_value()) {
@@ -75,7 +75,7 @@ String encoding_from_content_type(const String& content_type)
     return "utf-8";
 }
 
-String mime_type_from_content_type(const String& content_type)
+static String mime_type_from_content_type(const String& content_type)
 {
     auto offset = content_type.index_of(";");
     if (offset.has_value())