RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 07:17:34 +00:00
Code Issues Activity Actions

Kernel/ScatterGatherList: Move constructor init code to try_create

Browse source 
The constructor code of ScatterGatherList had code that can return
error. Move it to try_create for better error propagation.

This removes one TODO() and one
release_value_but_fixme_should_propagate_errors().
This commit is contained in:
Pankaj Raghav 2023-05-17 20:06:34 +02:00 • committed by Jelle Raaijmakers
parent 489e268b96
commit e067046474
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Memory/ScatterGatherList.h
View file

@ -25,9 +25,9 @@ public:
size_t scatters_count() const { return m_vm_object->physical_pages().size(); }
private:
ScatterGatherList(NonnullLockRefPtr<AnonymousVMObject>, AsyncBlockDeviceRequest&, size_t device_block_size);
ScatterGatherList(NonnullLockRefPtr<AnonymousVMObject>, NonnullOwnPtr<Region> dma_region);
NonnullLockRefPtr<AnonymousVMObject> m_vm_object;
OwnPtr<Region> m_dma_region;
NonnullOwnPtr<Region> m_dma_region;
};
}