From e08072ac2bbfea3a4ba3f194807ee040eab6787d Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Thu, 31 Aug 2023 20:48:32 +1200 Subject: [PATCH] LibWeb: Explicitly clear read requests for default stream reader Expecting the list to be cleared from the move() is quite strange and not particularly clear. Explicitly clear the requests instead. --- Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp b/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp index 01f1ee8348..847ded5a37 100644 --- a/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp +++ b/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp @@ -425,9 +425,11 @@ WebIDL::ExceptionOr readable_stream_reader_generic_release(ReadableStreamG void readable_stream_default_reader_error_read_requests(ReadableStreamDefaultReader& reader, JS::Value error) { // 1. Let readRequests be reader.[[readRequests]]. - // 2. Set reader.[[readRequests]] to a new empty list. auto read_requests = move(reader.read_requests()); + // 2. Set reader.[[readRequests]] to a new empty list. + reader.read_requests().clear(); + // 3. For each readRequest of readRequests, for (auto& read_request : read_requests) { // 1. Perform readRequest’s error steps, given e.