RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 10:07:44 +00:00
Code Issues Activity Actions

LibJS: Convert ProxyObject::create() to NonnullGCPtr

Browse source
This commit is contained in:
Linus Groh 2022-12-13 20:49:50 +00:00
parent 6e386acb11
commit e0818bf21e
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/ProxyConstructor.cpp
View file

@ -21,7 +21,7 @@ static ThrowCompletionOr<ProxyObject*> proxy_create(VM& vm, Value target, Value
return vm.throw_completion<TypeError>(ErrorType::ProxyConstructorBadType, "target", target.to_string_without_side_effects()); return vm.throw_completion<TypeError>(ErrorType::ProxyConstructorBadType, "target", target.to_string_without_side_effects());
if (!handler.is_object()) if (!handler.is_object())
return vm.throw_completion<TypeError>(ErrorType::ProxyConstructorBadType, "handler", handler.to_string_without_side_effects()); return vm.throw_completion<TypeError>(ErrorType::ProxyConstructorBadType, "handler", handler.to_string_without_side_effects());
return ProxyObject::create(realm, target.as_object(), handler.as_object()); return ProxyObject::create(realm, target.as_object(), handler.as_object()).ptr();
} }
ProxyConstructor::ProxyConstructor(Realm& realm) ProxyConstructor::ProxyConstructor(Realm& realm)

4
Userland/Libraries/LibJS/Runtime/ProxyObject.cpp
View file

@ -15,9 +15,9 @@
namespace JS { namespace JS {
ProxyObject* ProxyObject::create(Realm& realm, Object& target, Object& handler) NonnullGCPtr<ProxyObject> ProxyObject::create(Realm& realm, Object& target, Object& handler)
{ {
return realm.heap().allocate<ProxyObject>(realm, target, handler, *realm.intrinsics().object_prototype()); return *realm.heap().allocate<ProxyObject>(realm, target, handler, *realm.intrinsics().object_prototype());
} }
ProxyObject::ProxyObject(Object& target, Object& handler, Object& prototype) ProxyObject::ProxyObject(Object& target, Object& handler, Object& prototype)

2
Userland/Libraries/LibJS/Runtime/ProxyObject.h
View file

@ -16,7 +16,7 @@ class ProxyObject final : public FunctionObject {
JS_OBJECT(ProxyObject, FunctionObject); JS_OBJECT(ProxyObject, FunctionObject);
public: public:
static ProxyObject* create(Realm&, Object& target, Object& handler); static NonnullGCPtr<ProxyObject> create(Realm&, Object& target, Object& handler);
virtual ~ProxyObject() override = default; virtual ~ProxyObject() override = default;