RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:37:45 +00:00
Code Issues Activity Actions

LibJS: Use HashTable::remove_all_matching() in WeakSet :^)

Browse source
This commit is contained in:
Andreas Kling 2022-01-05 16:48:05 +01:00
parent 54cf42fac1
commit e08d325124
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibJS/Runtime/WeakSet.cpp
View file

@ -25,14 +25,9 @@ WeakSet::~WeakSet()
void WeakSet::remove_dead_cells(Badge<Heap>) void WeakSet::remove_dead_cells(Badge<Heap>)
{ {
// FIXME: Do this in a single pass. m_values.remove_all_matching([](Cell* cell) {
Vector<Cell*> to_remove; return cell->state() != Cell::State::Live;
for (auto* cell : m_values) { });
if (cell->state() != Cell::State::Live)
to_remove.append(cell);
}
for (auto* cell : to_remove)
m_values.remove(cell);
} }
} }