RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:07:36 +00:00
Code Issues Activity Actions

LibRegex: Allow missing high bound in {x,y} quantifiers

Browse source 
Fixes #5518.
This commit is contained in:
AnotherTest 2021-02-26 23:23:58 +03:30 • committed by Andreas Kling
parent 91bf3dc7fe
commit e0ac85288e
2 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibRegex/RegexParser.cpp
View file

@ -954,12 +954,10 @@ bool ECMA262Parser::parse_quantifier(ByteCode& stack, size_t& match_length_minim
if (match(TokenType::Comma)) { if (match(TokenType::Comma)) {
consume(); consume();
auto high_bound = read_digits(); auto high_bound = read_digits();
if (!high_bound.has_value()) { if (high_bound.has_value())
set_error(Error::InvalidBraceContent);
return false;
}
repeat_max = high_bound.value(); repeat_max = high_bound.value();
} else {
repeat_max = repeat_min;
} }
if (!match(TokenType::RightCurly)) { if (!match(TokenType::RightCurly)) {

1
Userland/Libraries/LibRegex/Tests/Regex.cpp
View file

@ -563,6 +563,7 @@ TEST_CASE(ECMA262_match)
{ "^(?:^^\\.?|[!+-]|!=|!==|#|%|%=|&|&&|&&=|&=|\\(|\\*|\\*=|\\+=|,|-=|->|\\/|\\/=|:|::|;|<|<<|<<=|<=|=|==|===|>|>=|>>|>>=|>>>|>>>=|[?@[^]|\\^=|\\^\\^|\\^\\^=|{|\\||\\|=|\\|\\||\\|\\|=|~|break|case|continue|delete|do|else|finally|instanceof|return|throw|try|typeof)\\s*(\\/(?=[^*/])(?:[^/[\\\\]|\\\\[\\S\\s]|\\[(?:[^\\\\\\]]|\\\\[\\S\\s])*(?:]|$))+\\/)", { "^(?:^^\\.?|[!+-]|!=|!==|#|%|%=|&|&&|&&=|&=|\\(|\\*|\\*=|\\+=|,|-=|->|\\/|\\/=|:|::|;|<|<<|<<=|<=|=|==|===|>|>=|>>|>>=|>>>|>>>=|[?@[^]|\\^=|\\^\\^|\\^\\^=|{|\\||\\|=|\\|\\||\\|\\|=|~|break|case|continue|delete|do|else|finally|instanceof|return|throw|try|typeof)\\s*(\\/(?=[^*/])(?:[^/[\\\\]|\\\\[\\S\\s]|\\[(?:[^\\\\\\]]|\\\\[\\S\\s])*(?:]|$))+\\/)",
"return /xx/", true, ECMAScriptFlags::BrowserExtended "return /xx/", true, ECMAScriptFlags::BrowserExtended
}, // #5517, appears to be matching JS expressions that involve regular expressions... }, // #5517, appears to be matching JS expressions that involve regular expressions...
{ "a{2,}", "aaaa" }, // #5518
}; };
// clang-format on // clang-format on