RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:58:12 +00:00
Code Issues Activity Actions

Kernel+SystemServer: Defer creation of device nodes to userspace

Browse source 
Don't create these device nodes in the Kernel, so we essentially enforce
userspace (SystemServer) to take control of this operation and to decide
how to create these device nodes.

This makes the DevFS to resemble linux devtmpfs, and allows us to remove
a bunch of unneeded overriding implementations of device name creation
in the Kernel.
This commit is contained in:
Liav A 2021-08-14 05:04:56 +03:00 • committed by Andreas Kling
parent fcc046047f
commit e0d712c6f7
7 changed files with 144 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Kernel/FileSystem/DevFS.h
View file

@ -24,10 +24,6 @@ public:
virtual KResult initialize() override;
virtual StringView class_name() const override { return "DevFS"sv; }
void notify_new_device(Device&);
void notify_device_removal(Device&);
virtual Inode& root_inode() override;
private:
@ -76,16 +72,19 @@ public:
virtual ~DevFSDeviceInode() override;
private:
DevFSDeviceInode(DevFS&, Device const&, NonnullOwnPtr<KString> name);
DevFSDeviceInode(DevFS&, unsigned, unsigned, bool, NonnullOwnPtr<KString> name);
// ^Inode
virtual KResultOr<size_t> read_bytes(off_t, size_t, UserOrKernelBuffer& buffer, OpenFileDescription*) const override;
virtual InodeMetadata metadata() const override;
virtual KResultOr<size_t> write_bytes(off_t, size_t, const UserOrKernelBuffer& buffer, OpenFileDescription*) override;
virtual KResult chown(UserID, GroupID) override;
virtual KResult chmod(mode_t) override;
NonnullRefPtr<Device> m_attached_device;
NonnullOwnPtr<KString> m_name;
const unsigned m_major_number;
const unsigned m_minor_number;
const bool m_block_device;
mode_t m_required_mode;
UserID m_uid { 0 };
GroupID m_gid { 0 };
};