RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

LibWeb: Make WindowObject's prototype immutable

Browse source 
While I was implementing IDL special operations, I noticed that for
global platform objects (e.g. WindowObject), the IDL spec makes their
prototype immutable.

https://heycam.github.io/webidl/#platform-object-setprototypeof
This commit is contained in:
Luke Wilde 2021-09-26 15:26:30 +01:00 • committed by Andreas Kling
parent f6b24a72ee
commit e0e41116a4
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Bindings/WindowObject.cpp
View file

@ -136,6 +136,13 @@ Origin WindowObject::origin() const
return impl().associated_document().origin(); return impl().associated_document().origin();
} }
// https://heycam.github.io/webidl/#platform-object-setprototypeof
bool WindowObject::internal_set_prototype_of(JS::Object* prototype)
{
// 1. Return ? SetImmutablePrototype(O, V).
return set_immutable_prototype(prototype);
}
static DOM::Window* impl_from(JS::VM& vm, JS::GlobalObject& global_object) static DOM::Window* impl_from(JS::VM& vm, JS::GlobalObject& global_object)
{ {
// Since this is a non built-in function we must treat it as non-strict mode // Since this is a non built-in function we must treat it as non-strict mode

2
Userland/Libraries/LibWeb/Bindings/WindowObject.h
View file

@ -60,6 +60,8 @@ public:
return *constructor; return *constructor;
} }
virtual bool internal_set_prototype_of(JS::Object* prototype) override;
private: private:
virtual void visit_edges(Visitor&) override; virtual void visit_edges(Visitor&) override;