RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:18:12 +00:00
Code Issues Activity Actions

LibJS: Follow the spec with storing im- and export entries

Browse source 
Because we can have arbitrary in- and export names with strings we can
have '*' and '' which means using '*' as an indicating namespace imports
failed / behaved incorrectly for string imports '*'.
We now use more specific types to indicate these special states instead
of these 'magic' string values.

Do note that 'default' is not actually a magic string value but one
specified by the spec. And you can in fact export the default value by
doing: `export { 1 as default }`.
This commit is contained in:
davidot 2022-01-27 01:54:47 +01:00 • committed by Linus Groh
parent 8473f6caee
commit e0e4ead2c8
11 changed files with 190 additions and 96 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Tests/modules/indirect-export-without-default.mjs Normal file
View file

@ -0,0 +1,3 @@
// Since 'default-and-star-export-indirect.mjs' only contains an all-but-default re export of
// 'default-and-star-export.mjs' it should not have a default value.
import defaultExportIndirect from "./default-and-star-export-indirect.mjs";