RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 23:58:11 +00:00
Code Issues Activity Actions

LibWeb: Remove inheritance of TableBox from BlockContainer

Browse source 
Fixup rule that table roots need to be wrapped in anonymous
block boxes need to be implemeted instead of having `TableBox`
inherited from `BlockContainer`.
This commit is contained in:
Aliaksandr Kalenik 2023-01-09 07:25:05 +03:00 • committed by Andreas Kling
parent c8337e9ee8
commit e107c83a57
4 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Layout/TableBox.cpp
View file

@ -10,12 +10,12 @@
namespace Web::Layout {
TableBox::TableBox(DOM::Document& document, DOM::Element* element, NonnullRefPtr<CSS::StyleProperties> style)
: Layout::BlockContainer(document, element, move(style))
: Layout::Box(document, element, move(style))
{
}
TableBox::TableBox(DOM::Document& document, DOM::Element* element, CSS::ComputedValues computed_values)
: Layout::BlockContainer(document, element, move(computed_values))
: Layout::Box(document, element, move(computed_values))
{
}

6
Userland/Libraries/LibWeb/Layout/TableBox.h
View file

@ -6,12 +6,12 @@
#pragma once
#include <LibWeb/Layout/BlockContainer.h>
#include <LibWeb/Layout/Box.h>
namespace Web::Layout {
class TableBox final : public Layout::BlockContainer {
JS_CELL(TableBox, BlockContainer);
class TableBox final : public Layout::Box {
JS_CELL(TableBox, Box);
public:
TableBox(DOM::Document&, DOM::Element*, NonnullRefPtr<CSS::StyleProperties>);

2
Userland/Libraries/LibWeb/Layout/TableFormattingContext.cpp
View file

@ -36,7 +36,7 @@ struct Traits<GridPosition> : public GenericTraits<GridPosition> {
namespace Web::Layout {
TableFormattingContext::TableFormattingContext(LayoutState& state, BlockContainer const& root, FormattingContext* parent)
TableFormattingContext::TableFormattingContext(LayoutState& state, TableBox const& root, FormattingContext* parent)
: FormattingContext(Type::Table, state, root, parent)
{
}

2
Userland/Libraries/LibWeb/Layout/TableFormattingContext.h
View file

@ -13,7 +13,7 @@ namespace Web::Layout {
class TableFormattingContext final : public FormattingContext {
public:
explicit TableFormattingContext(LayoutState&, BlockContainer const&, FormattingContext* parent);
explicit TableFormattingContext(LayoutState&, TableBox const&, FormattingContext* parent);
~TableFormattingContext();
virtual void run(Box const&, LayoutMode, AvailableSpace const&) override;