RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 15:42:44 +00:00
Code Issues Activity Actions

LibWeb: Generate setter for [Replaceable] IDL attributes

Browse source 
The code is directly stolen from the REPLACEABLE_PROPERTY_SETTER() macro
which will hopefully be removed soon.
This commit is contained in:
Linus Groh 2023-03-06 14:10:39 +00:00
parent 3316d247bf
commit e13f89c9eb
1 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -2128,7 +2128,7 @@ static void generate_prototype_or_global_mixin_declarations(IDL::Interface const
JS_DECLARE_NATIVE_FUNCTION(@attribute.name:snakecase@_getter); JS_DECLARE_NATIVE_FUNCTION(@attribute.name:snakecase@_getter);
)~~~"); )~~~");
if (!attribute.readonly) { if (!attribute.readonly || attribute.extended_attributes.contains("Replaceable"sv)) {
attribute_generator.append(R"~~~( attribute_generator.append(R"~~~(
JS_DECLARE_NATIVE_FUNCTION(@attribute.name:snakecase@_setter); JS_DECLARE_NATIVE_FUNCTION(@attribute.name:snakecase@_setter);
)~~~"); )~~~");
@ -2250,10 +2250,10 @@ JS::ThrowCompletionOr<void> @class_name@::initialize(JS::Realm& realm)
attribute_generator.set("attribute.name", attribute.name); attribute_generator.set("attribute.name", attribute.name);
attribute_generator.set("attribute.getter_callback", attribute.getter_callback_name); attribute_generator.set("attribute.getter_callback", attribute.getter_callback_name);
if (attribute.readonly) if (!attribute.readonly || attribute.extended_attributes.contains("Replaceable"sv))
attribute_generator.set("attribute.setter_callback", "nullptr");
else
attribute_generator.set("attribute.setter_callback", attribute.setter_callback_name); attribute_generator.set("attribute.setter_callback", attribute.setter_callback_name);
else
attribute_generator.set("attribute.setter_callback", "nullptr");
if (attribute.extended_attributes.contains("Unscopable")) { if (attribute.extended_attributes.contains("Unscopable")) {
attribute_generator.append(R"~~~( attribute_generator.append(R"~~~(
@ -2394,6 +2394,7 @@ static JS::ThrowCompletionOr<@fully_qualified_name@*> impl_from(JS::VM& vm)
for (auto& attribute : interface.attributes) { for (auto& attribute : interface.attributes) {
auto attribute_generator = generator.fork(); auto attribute_generator = generator.fork();
attribute_generator.set("attribute.name", attribute.name);
attribute_generator.set("attribute.getter_callback", attribute.getter_callback_name); attribute_generator.set("attribute.getter_callback", attribute.getter_callback_name);
attribute_generator.set("attribute.setter_callback", attribute.setter_callback_name); attribute_generator.set("attribute.setter_callback", attribute.setter_callback_name);
@ -2478,6 +2479,17 @@ JS_DEFINE_NATIVE_FUNCTION(@class_name@::@attribute.setter_callback@)
attribute_generator.append(R"~~~( attribute_generator.append(R"~~~(
return JS::js_undefined(); return JS::js_undefined();
} }
)~~~");
} else if (attribute.extended_attributes.contains("Replaceable"sv)) {
attribute_generator.append(R"~~~(
JS_DEFINE_NATIVE_FUNCTION(@class_name@::@attribute.setter_callback@)
{
auto this_value = vm.this_value();
if (!this_value.is_object() || !is<@fully_qualified_name@>(this_value.as_object()))
return vm.throw_completion<JS::TypeError>(JS::ErrorType::NotAnObjectOfType, "@name@");
TRY(this_value.as_object().internal_define_own_property("@attribute.name@", JS::PropertyDescriptor { .value = vm.argument(0), .writable = true }));
return JS::js_undefined();
}
)~~~"); )~~~");
} }
} }