From e1779b064a8f8967ee11bf3dacff453b426f59fa Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 21 Nov 2021 12:26:12 +0100 Subject: [PATCH] Kernel: Remove bogus TODO in coredump generation When dumping the memory contents of a process, we should not page in things from inodes that were not already paged in. --- Kernel/Coredump.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/Kernel/Coredump.cpp b/Kernel/Coredump.cpp index 7d94784be2..85fda720fd 100644 --- a/Kernel/Coredump.cpp +++ b/Kernel/Coredump.cpp @@ -186,8 +186,6 @@ ErrorOr Coredump::write_regions() if (page) return UserOrKernelBuffer::for_user_buffer(reinterpret_cast((region->vaddr().as_ptr() + (i * PAGE_SIZE))), PAGE_SIZE); // If the current page is not backed by a physical page, we zero it in the coredump file. - // TODO: Do we want to include the contents of pages that have not been faulted-in in the coredump? - // (A page may not be backed by a physical page because it has never been faulted in when the process ran). return UserOrKernelBuffer::for_kernel_buffer(zero_buffer); }(); TRY(m_description->write(src_buffer.value(), PAGE_SIZE));