RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:37:43 +00:00
Code Issues Activity Actions

WindowServer: Recompute occlusions and re-render shadows on theme change

Browse source 
Since theme changes may change geometrics, which are also affected by
window shadows, we need to recompute occlusions as well as re-render
window frames.
This commit is contained in:
Tom 2021-02-09 13:12:59 -07:00 • committed by Andreas Kling
parent ace1b34798
commit e1ee59ac9d
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Services/WindowServer/WindowFrame.h
View file

@ -85,6 +85,13 @@ public:
m_dirty = true; m_dirty = true;
} }
void theme_changed()
{
m_dirty = m_shadow_dirty = true;
layout_buttons();
set_button_icons();
}
private: private:
void paint_simple_rect_shadow(Gfx::Painter&, const Gfx::IntRect&, const Gfx::Bitmap&) const; void paint_simple_rect_shadow(Gfx::Painter&, const Gfx::IntRect&, const Gfx::Bitmap&) const;
void paint_notification_frame(Gfx::Painter&); void paint_notification_frame(Gfx::Painter&);

4
Userland/Services/WindowServer/WindowManager.cpp
View file

@ -1432,14 +1432,14 @@ bool WindowManager::update_theme(String theme_path, String theme_name)
notified_clients.set(window.client()); notified_clients.set(window.client());
} }
} }
window.frame().layout_buttons(); window.frame().theme_changed();
window.frame().set_button_icons();
return IterationDecision::Continue; return IterationDecision::Continue;
}); });
MenuManager::the().did_change_theme(); MenuManager::the().did_change_theme();
auto wm_config = Core::ConfigFile::open("/etc/WindowServer/WindowServer.ini"); auto wm_config = Core::ConfigFile::open("/etc/WindowServer/WindowServer.ini");
wm_config->write_entry("Theme", "Name", theme_name); wm_config->write_entry("Theme", "Name", theme_name);
wm_config->sync(); wm_config->sync();
Compositor::the().invalidate_occlusions();
Compositor::the().invalidate_screen(); Compositor::the().invalidate_screen();
return true; return true;
} }