From e2187f29563dbbdcc91e0ff6b84a9933621c0cda Mon Sep 17 00:00:00 2001 From: ngc6302h Date: Mon, 28 Jun 2021 17:13:31 +0200 Subject: [PATCH] SoundPlayer: Don't limit duration inference to WAV files --- .../SoundPlayer/SoundPlayerWidgetAdvancedView.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp b/Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp index b0f2cd4751..c4728c5774 100644 --- a/Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp +++ b/Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp @@ -302,10 +302,8 @@ void SoundPlayerWidgetAdvancedView::try_fill_missing_info(Vector& entr if (!entry.extended_info->track_display_title.has_value()) entry.extended_info->track_display_title = LexicalPath(entry.path).title(); if (!entry.extended_info->track_length_in_seconds.has_value()) { - if (entry_path.has_extension("wav")) { - auto wav_reader = Audio::Loader::create(entry.path); - entry.extended_info->track_length_in_seconds = wav_reader->total_samples() / wav_reader->sample_rate(); - } + if (auto reader = Audio::Loader::create(entry.path); !reader->has_error()) + entry.extended_info->track_length_in_seconds = reader->total_samples() / reader->sample_rate(); //TODO: Implement embedded metadata extractor for other audio formats } //TODO: Implement a metadata parser for the uncomfortably numerous popular embedded metadata formats