RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 22:17:42 +00:00
Code Issues Activity Actions

LibWeb+WebContent: Remove old console-logging IPC calls

Browse source 
This patch removes the following WebContent IPC calls, which are no
longer used:

- `Server::js_console_initialize()`
- `Client::did_js_console_output()`
This commit is contained in:
Sam Atkins 2021-09-04 12:29:25 +01:00 • committed by Andreas Kling
parent 95aa6562db
commit e255b5dd31
9 changed files with 0 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWeb/OutOfProcessWebView.cpp
View file

@ -347,12 +347,6 @@ void OutOfProcessWebView::notify_server_did_get_dom_node_properties(i32 node_id,
on_get_dom_node_properties(node_id, specified_style, computed_style);
}
void OutOfProcessWebView::notify_server_did_js_console_output(const String& method, const String& line)
{
if (on_js_console_output)
on_js_console_output(method, line);
}
void OutOfProcessWebView::notify_server_did_output_js_console_message(i32 message_index)
{
if (on_js_console_new_message)
@ -441,11 +435,6 @@ i32 OutOfProcessWebView::get_hovered_node_id()
return client().get_hovered_node_id();
}
void OutOfProcessWebView::js_console_initialize()
{
client().async_js_console_initialize();
}
void OutOfProcessWebView::js_console_input(const String& js_source)
{
client().async_js_console_input(js_source);

2
Userland/Libraries/LibWeb/OutOfProcessWebView.h
View file

@ -41,7 +41,6 @@ public:
void clear_inspected_dom_node();
i32 get_hovered_node_id();
void js_console_initialize();
void js_console_input(const String& js_source);
void js_console_request_messages(i32 start_index);
@ -75,7 +74,6 @@ public:
void notify_server_did_get_source(const URL& url, const String& source);
void notify_server_did_get_dom_tree(const String& dom_tree);
void notify_server_did_get_dom_node_properties(i32 node_id, String const& specified_style, String const& computed_style);
void notify_server_did_js_console_output(const String& method, const String& line);
void notify_server_did_output_js_console_message(i32 message_index);
void notify_server_did_get_js_console_messages(i32 start_index, Vector<String> const& message_types, Vector<String> const& messages);
void notify_server_did_change_favicon(const Gfx::Bitmap& favicon);

5
Userland/Libraries/LibWeb/WebContentClient.cpp
View file

@ -146,11 +146,6 @@ void WebContentClient::did_get_dom_node_properties(i32 node_id, String const& sp
m_view.notify_server_did_get_dom_node_properties(node_id, specified_style, computed_style);
}
void WebContentClient::did_js_console_output(String const& method, String const& line)
{
m_view.notify_server_did_js_console_output(method, line);
}
void WebContentClient::did_output_js_console_message(i32 message_index)
{
m_view.notify_server_did_output_js_console_message(message_index);

1
Userland/Libraries/LibWeb/WebContentClient.h
View file

@ -51,7 +51,6 @@ private:
virtual void did_get_source(URL const&, String const&) override;
virtual void did_get_dom_tree(String const&) override;
virtual void did_get_dom_node_properties(i32 node_id, String const& specified_style, String const& computed_style) override;
virtual void did_js_console_output(String const&, String const&) override;
virtual void did_output_js_console_message(i32 message_index) override;
virtual void did_get_js_console_messages(i32 start_index, Vector<String> const& message_types, Vector<String> const& messages) override;
virtual void did_change_favicon(Gfx::ShareableBitmap const&) override;

1
Userland/Libraries/LibWeb/WebViewHooks.h
View file

@ -29,7 +29,6 @@ public:
Function<void(const URL&, const String&)> on_get_source;
Function<void(const String&)> on_get_dom_tree;
Function<void(i32 node_id, String const& specified_style, String const& computed_style)> on_get_dom_node_properties;
Function<void(const String& method, const String& line)> on_js_console_output;
Function<void(i32 message_id)> on_js_console_new_message;
Function<void(i32 start_index, Vector<String> const& message_types, Vector<String> const& messages)> on_get_js_console_messages;
Function<String(const URL& url, Cookie::Source source)> on_get_cookie;

13
Userland/Services/WebContent/ClientConnection.cpp
View file

@ -270,19 +270,6 @@ Messages::WebContentServer::GetHoveredNodeIdResponse ClientConnection::get_hover
return (i32)0;
}
void ClientConnection::js_console_initialize()
{
if (auto* document = page().top_level_browsing_context().document()) {
auto interpreter = document->interpreter().make_weak_ptr();
if (m_interpreter.ptr() == interpreter.ptr())
return;
m_interpreter = interpreter;
m_console_client = make<WebContentConsoleClient>(interpreter->global_object().console(), interpreter, *this);
interpreter->global_object().console().set_client(*m_console_client.ptr());
}
}
void ClientConnection::initialize_js_console(Badge<PageHost>)
{
auto* document = page().top_level_browsing_context().document();

1
Userland/Services/WebContent/ClientConnection.h
View file

@ -55,7 +55,6 @@ private:
virtual Messages::WebContentServer::InspectDomNodeResponse inspect_dom_node(i32) override;
virtual Messages::WebContentServer::GetHoveredNodeIdResponse get_hovered_node_id() override;
virtual void js_console_initialize() override;
virtual void js_console_input(String const&) override;
virtual void run_javascript(String const&) override;
virtual void js_console_request_messages(i32) override;

1
Userland/Services/WebContent/WebContentClient.ipc
View file

@ -29,7 +29,6 @@ endpoint WebContentClient
did_get_source(URL url, String source) =|
did_get_dom_tree(String dom_tree) =|
did_get_dom_node_properties(i32 node_id, String specified_style, String computed_style) =|
did_js_console_output(String method, String line) =|
did_change_favicon(Gfx::ShareableBitmap favicon) =|
did_request_cookie(URL url, u8 source) => (String cookie)
did_set_cookie(URL url, Web::Cookie::ParsedCookie cookie, u8 source) =|

1
Userland/Services/WebContent/WebContentServer.ipc
View file

@ -29,7 +29,6 @@ endpoint WebContentServer
inspect_dom_tree() =|
inspect_dom_node(i32 node_id) => (bool has_style, String specified_style, String computed_style)
get_hovered_node_id() => (i32 node_id)
js_console_initialize() =|
js_console_input(String js_source) =|
js_console_request_messages(i32 start_index) =|