From e2566d5126e050691db2946126a92baec045588a Mon Sep 17 00:00:00 2001 From: Arda Cinar Date: Thu, 15 Dec 2022 18:45:31 +0300 Subject: [PATCH] LibMarkdown: Prevent a crash when rendering code blocks to console When parsing a code block not in a section (in a file without a heading), the parser would initialize the code block with an uninitialized (invalid) value for current_section. Accessing this value would later cause a segmentation fault in render_to_terminal. --- Userland/Libraries/LibMarkdown/ContainerBlock.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibMarkdown/ContainerBlock.cpp b/Userland/Libraries/LibMarkdown/ContainerBlock.cpp index 99c6f4af64..f137e470d3 100644 --- a/Userland/Libraries/LibMarkdown/ContainerBlock.cpp +++ b/Userland/Libraries/LibMarkdown/ContainerBlock.cpp @@ -91,7 +91,7 @@ OwnPtr ContainerBlock::parse(LineIterator& lines) NonnullOwnPtrVector blocks; StringBuilder paragraph_text; - Heading* current_section; + Heading* current_section = nullptr; auto flush_paragraph = [&] { if (paragraph_text.is_empty())