RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:57:35 +00:00
Code Issues Activity Actions

LibVT+Kernel: Separate the caret shapes and its steadiness

Browse source 
Currently CursorStyle enum handles both the styles and the steadiness or
blinking of the terminal caret, which doubles the amount of its entries.
This commit changes CursorStyle to CursorShape and moves the blinking
option to a seperate boolean value.
This commit is contained in:
Michał Lach 2022-05-12 22:52:14 +02:00 • committed by Sam Atkins
parent 1950e79d48
commit e2b0f6795f
6 changed files with 101 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibVT/TerminalWidget.h
View file

@ -96,6 +96,13 @@ public:
void set_color_scheme(StringView);
VT::CursorShape cursor_shape() { return m_cursor_shape; }
virtual void set_cursor_blinking(bool) override;
virtual void set_cursor_shape(CursorShape) override;
static Optional<VT::CursorShape> parse_cursor_shape(StringView);
static String stringify_cursor_shape(VT::CursorShape);
private:
TerminalWidget(int ptm_fd, bool automatic_size_policy);
@ -124,7 +131,6 @@ private:
virtual void terminal_did_resize(u16 columns, u16 rows) override;
virtual void terminal_history_changed(int delta) override;
virtual void emit(u8 const*, size_t) override;
virtual void set_cursor_style(CursorStyle) override;
// ^GUI::Clipboard::ClipboardClient
virtual void clipboard_content_did_change(String const&) override { update_paste_action(); }
@ -196,7 +202,8 @@ private:
bool m_cursor_blink_state { true };
bool m_automatic_size_policy { false };
VT::CursorStyle m_cursor_style { BlinkingBlock };
VT::CursorShape m_cursor_shape { VT::CursorShape::Block };
bool m_cursor_is_blinking_set { true };
enum class AutoScrollDirection {
None,