mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 17:17:45 +00:00
Everywhere: Use to_number<T> instead of to_{int,uint,float,double}
In a bunch of cases, this actually ends up simplifying the code as to_number will handle something such as: ``` Optional<I> opt; if constexpr (IsSigned<I>) opt = view.to_int<I>(); else opt = view.to_uint<I>(); ``` For us. The main goal here however is to have a single generic number conversion API between all of the String classes.
This commit is contained in:
parent
a4ecc65398
commit
e2e7c4d574
155 changed files with 397 additions and 412 deletions
|
@ -1,4 +1,5 @@
|
|||
/*
|
||||
* Copyright (c) 2019-2023, Shannon Booth <shannon@serenityos.org>
|
||||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
|
@ -188,8 +189,8 @@ NonnullRefPtr<GUI::Widget> EllipseTool::get_properties_widget()
|
|||
m_aspect_w_textbox->set_fixed_height(20);
|
||||
m_aspect_w_textbox->set_fixed_width(25);
|
||||
m_aspect_w_textbox->on_change = [this] {
|
||||
auto x = m_aspect_w_textbox->text().to_int().value_or(0);
|
||||
auto y = m_aspect_h_textbox->text().to_int().value_or(0);
|
||||
auto x = m_aspect_w_textbox->text().to_number<int>().value_or(0);
|
||||
auto y = m_aspect_h_textbox->text().to_number<int>().value_or(0);
|
||||
if (x > 0 && y > 0) {
|
||||
m_aspect_ratio = (float)x / (float)y;
|
||||
} else {
|
||||
|
|
|
@ -237,8 +237,8 @@ NonnullRefPtr<GUI::Widget> RectangleTool::get_properties_widget()
|
|||
m_aspect_w_textbox->set_fixed_height(20);
|
||||
m_aspect_w_textbox->set_fixed_width(25);
|
||||
m_aspect_w_textbox->on_change = [this] {
|
||||
auto x = m_aspect_w_textbox->text().to_int().value_or(0);
|
||||
auto y = m_aspect_h_textbox->text().to_int().value_or(0);
|
||||
auto x = m_aspect_w_textbox->text().to_number<int>().value_or(0);
|
||||
auto y = m_aspect_h_textbox->text().to_number<int>().value_or(0);
|
||||
if (x > 0 && y > 0) {
|
||||
m_aspect_ratio = (float)x / (float)y;
|
||||
} else {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue