RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:47:35 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/SpinBox.cpp
View file

@ -24,7 +24,7 @@ SpinBox::SpinBox()
if (!weak_this)
return;
auto value = m_editor->text().to_uint();
auto value = m_editor->text().to_number<unsigned>();
if (!value.has_value() && m_editor->text().length() > 0)
m_editor->do_delete();
};
@ -81,7 +81,7 @@ void SpinBox::set_value_from_current_text()
if (m_editor->text().is_empty())
return;
auto value = m_editor->text().to_int();
auto value = m_editor->text().to_number<int>();
if (value.has_value())
set_value(value.value());
else