mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 07:07:44 +00:00
Everywhere: Use to_number<T> instead of to_{int,uint,float,double}
In a bunch of cases, this actually ends up simplifying the code as to_number will handle something such as: ``` Optional<I> opt; if constexpr (IsSigned<I>) opt = view.to_int<I>(); else opt = view.to_uint<I>(); ``` For us. The main goal here however is to have a single generic number conversion API between all of the String classes.
This commit is contained in:
parent
a4ecc65398
commit
e2e7c4d574
155 changed files with 397 additions and 412 deletions
|
@ -121,7 +121,7 @@ OwnPtr<List> List::parse(LineIterator& lines)
|
|||
continue;
|
||||
if (ch == '.' || ch == ')')
|
||||
if (i + 1 < line.length() && line[i + 1] == ' ') {
|
||||
auto maybe_start_number = line.substring_view(offset, i - offset).to_uint<size_t>();
|
||||
auto maybe_start_number = line.substring_view(offset, i - offset).to_number<size_t>();
|
||||
if (!maybe_start_number.has_value())
|
||||
break;
|
||||
if (first)
|
||||
|
|
|
@ -643,7 +643,7 @@ NonnullOwnPtr<Text::Node> Text::parse_link(Vector<Token>::ConstIterator& tokens)
|
|||
|
||||
auto width_string = dimensions.substring_view(1, *dimension_seperator - 1);
|
||||
if (!width_string.is_empty()) {
|
||||
auto width = width_string.to_int();
|
||||
auto width = width_string.to_number<int>();
|
||||
if (!width.has_value())
|
||||
return false;
|
||||
image_width = width;
|
||||
|
@ -652,7 +652,7 @@ NonnullOwnPtr<Text::Node> Text::parse_link(Vector<Token>::ConstIterator& tokens)
|
|||
auto height_start = *dimension_seperator + 1;
|
||||
if (height_start < dimensions.length()) {
|
||||
auto height_string = dimensions.substring_view(height_start);
|
||||
auto height = height_string.to_int();
|
||||
auto height = height_string.to_number<int>();
|
||||
if (!height.has_value())
|
||||
return false;
|
||||
image_height = height;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue