RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:24:57 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Utilities/asctl.cpp
View file

@ -105,7 +105,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
}
auto& variable = command_arguments[i];
if (variable.is_one_of("v"sv, "volume"sv)) {
auto volume = command_arguments[++i].to_int();
auto volume = command_arguments[++i].to_number<int>();
if (!volume.has_value()) {
warnln("Error: {} is not an integer volume", command_arguments[i - 1]);
return 1;
@ -128,7 +128,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
}
values_to_set.set(AudioVariable::Mute, mute);
} else if (variable.is_one_of("r"sv, "samplerate"sv)) {
auto sample_rate = command_arguments[++i].to_int();
auto sample_rate = command_arguments[++i].to_number<int>();
if (!sample_rate.has_value()) {
warnln("Error: {} is not an integer sample rate", command_arguments[i - 1]);
return 1;