RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:47:35 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/id.cpp
View file

@ -50,7 +50,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
Optional<Core::Account> account;
if (!user_str.is_empty()) {
if (auto user_id = user_str.to_uint(); user_id.has_value())
if (auto user_id = user_str.to_number<uid_t>(); user_id.has_value())
account = TRY(Core::Account::from_uid(user_id.value(), Core::Account::Read::PasswdOnly));
else
account = TRY(Core::Account::from_name(user_str, Core::Account::Read::PasswdOnly));