RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 08:54:58 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/json.cpp
View file

@ -141,7 +141,7 @@ JsonValue query(JsonValue const& value, Vector<StringView>& key_parts, size_t ke
if (value.is_object()) {
result = value.as_object().get(key).value_or({});
} else if (value.is_array()) {
auto key_as_index = key.to_int();
auto key_as_index = key.to_number<int>();
if (key_as_index.has_value())
result = value.as_array().at(key_as_index.value());
}