RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 08:54:58 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Utilities/kill.cpp
View file

@ -61,7 +61,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
}
if (!number.has_value())
number = strings[1].substring_view(1).to_uint();
number = strings[1].substring_view(1).to_number<unsigned>();
if (!number.has_value()) {
warnln("'{}' is not a valid signal name or number", &strings[1][1]);
@ -69,7 +69,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
}
signum = number.value();
}
auto pid_opt = strings[pid_argi].to_int();
auto pid_opt = strings[pid_argi].to_number<pid_t>();
if (!pid_opt.has_value()) {
warnln("'{}' is not a valid PID", strings[pid_argi]);
return 3;