RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:04:59 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Utilities/pixelflut.cpp
View file

@ -43,7 +43,7 @@ ErrorOr<NonnullRefPtr<Client>> Client::create(StringView image_path, StringView
{
// Extract hostname and port and connect to server.
auto parts = server.split_view(':');
auto maybe_port = parts.take_last().to_uint();
auto maybe_port = parts.take_last().to_number<unsigned>();
if (!maybe_port.has_value())
return Error::from_string_view("Invalid port number"sv);
@ -60,8 +60,8 @@ ErrorOr<NonnullRefPtr<Client>> Client::create(StringView image_path, StringView
return Error::from_string_view("Server didn't return size correctly"sv);
auto size_parts = size_line.split_view(' ');
auto maybe_width = size_parts[1].to_uint();
auto maybe_height = size_parts[2].to_uint();
auto maybe_width = size_parts[1].to_number<unsigned>();
auto maybe_height = size_parts[2].to_number<unsigned>();
if (!maybe_width.has_value() || !maybe_height.has_value())
return Error::from_string_view("Width or height invalid"sv);