RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:04:59 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Utilities/pkill.cpp
View file

@ -50,7 +50,7 @@ ErrorOr<int> serenity_main(Main::Arguments args)
.short_name = 'O',
.value_name = "seconds",
.accept_value = [&display_if_older_than](StringView seconds_string) {
auto number = seconds_string.to_uint<u64>();
auto number = seconds_string.to_number<u64>();
if (number.has_value() && number.value() <= NumericLimits<i64>::max()) {
auto now_time = UnixDateTime::now();
@ -72,7 +72,7 @@ ErrorOr<int> serenity_main(Main::Arguments args)
if (is_ascii_alpha(signal_string[0]))
signal = getsignalbyname(&signal_string[0]);
else if (auto maybe_signal = signal_string.to_int(); maybe_signal.has_value())
else if (auto maybe_signal = signal_string.to_number<int>(); maybe_signal.has_value())
signal = maybe_signal.value();
if (signal <= 0 || signal >= NSIG)
@ -89,7 +89,7 @@ ErrorOr<int> serenity_main(Main::Arguments args)
.value_name = "uid-list",
.accept_value = [&uids_to_filter_by](StringView comma_separated_users) {
for (auto user_string : comma_separated_users.split_view(',')) {
auto maybe_uid = user_string.to_uint<uid_t>();
auto maybe_uid = user_string.to_number<uid_t>();
if (maybe_uid.has_value()) {
uids_to_filter_by.set(maybe_uid.value());
} else {