RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:34:59 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Utilities/pmemdump.cpp
View file

@ -22,10 +22,10 @@
static bool try_set_offset_and_length_parameters(ByteString const& arg_offset, ByteString const& arg_length, u64& offset, u64& length)
{
// TODO: Add support for hex values
auto possible_offset = arg_offset.to_uint<u64>();
auto possible_offset = arg_offset.to_number<u64>();
if (!possible_offset.has_value())
return false;
auto possible_length = arg_length.to_uint<u64>();
auto possible_length = arg_length.to_number<u64>();
if (!possible_length.has_value())
return false;
offset = possible_offset.value();