RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:34:59 +00:00
Code Issues Activity Actions

Everywhere: Use to_number<T> instead of to_{int,uint,float,double}

Browse source 
In a bunch of cases, this actually ends up simplifying the code as
to_number will handle something such as:

```
Optional<I> opt;
if constexpr (IsSigned<I>)
    opt = view.to_int<I>();
else
    opt = view.to_uint<I>();
```

For us.

The main goal here however is to have a single generic number conversion
API between all of the String classes.
This commit is contained in:
Shannon Booth 2023-12-23 15:59:14 +13:00 • committed by Andreas Kling
parent a4ecc65398
commit e2e7c4d574
155 changed files with 397 additions and 412 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/useradd.cpp
View file

@ -31,7 +31,7 @@ constexpr auto DEFAULT_SHELL = "/bin/sh"sv;
static Optional<gid_t> group_string_to_gid(StringView group)
{
auto maybe_gid = group.to_uint<gid_t>();
auto maybe_gid = group.to_number<gid_t>();
auto maybe_group_or_error = maybe_gid.has_value()
? Core::System::getgrgid(maybe_gid.value())
: Core::System::getgrnam(group);