From e3195b060d2cfbee101a8d152119b6fdc9f907ac Mon Sep 17 00:00:00 2001 From: Daniel Bertalan Date: Fri, 17 Mar 2023 17:41:53 +0100 Subject: [PATCH] LibVT: Fix integer overflow when parsing long OSC sequences We were storing indices into OSC escape sequences as `u8`s, which overflow at a length of just 256 characters. This caused a crash when parsing OSC 8 hyperlinks pointing to long filenames. --- Userland/Libraries/LibVT/EscapeSequenceParser.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibVT/EscapeSequenceParser.h b/Userland/Libraries/LibVT/EscapeSequenceParser.h index a5153f5505..54a9611075 100644 --- a/Userland/Libraries/LibVT/EscapeSequenceParser.h +++ b/Userland/Libraries/LibVT/EscapeSequenceParser.h @@ -69,7 +69,7 @@ private: Vector m_param_vector; unsigned m_param { 0 }; - Vector m_osc_parameter_indexes; + Vector m_osc_parameter_indexes; Vector m_osc_raw; bool m_ignoring { false };