RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:17:36 +00:00
Code Issues Activity Actions

LibWeb: Rename Element::specified_css_values() => computed_css_values()

Browse source 
Let's make it very clear that these are *computed* values, and not at
all the specified values. The specified values are currently discarded
by the CSS cascade algorithm.
This commit is contained in:
Andreas Kling 2022-03-15 19:41:35 +01:00
parent 43ef813f3d
commit e31fe3eeb8
6 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -271,12 +271,12 @@ void Element::recompute_style()
{
set_needs_style_update(false);
VERIFY(parent());
auto new_specified_css_values = document().style_computer().compute_style(*this);
auto new_computed_css_values = document().style_computer().compute_style(*this);
if (m_specified_css_values && *m_specified_css_values == *new_specified_css_values)
if (m_computed_css_values && *m_computed_css_values == *new_computed_css_values)
return;
m_specified_css_values = move(new_specified_css_values);
m_computed_css_values = move(new_computed_css_values);
document().invalidate_layout();
}

6
Userland/Libraries/LibWeb/DOM/Element.h
View file

@ -94,8 +94,8 @@ public:
String name() const { return attribute(HTML::AttributeNames::name); }
CSS::StyleProperties const* specified_css_values() const { return m_specified_css_values.ptr(); }
void set_specified_css_values(RefPtr<CSS::StyleProperties> style) { m_specified_css_values = move(style); }
CSS::StyleProperties const* computed_css_values() const { return m_computed_css_values.ptr(); }
void set_computed_css_values(RefPtr<CSS::StyleProperties> style) { m_computed_css_values = move(style); }
NonnullRefPtr<CSS::StyleProperties> resolved_css_values();
const CSS::CSSStyleDeclaration* inline_style() const { return m_inline_style; }
@ -149,7 +149,7 @@ private:
RefPtr<CSS::CSSStyleDeclaration> m_inline_style;
RefPtr<CSS::StyleProperties> m_specified_css_values;
RefPtr<CSS::StyleProperties> m_computed_css_values;
HashMap<FlyString, CSS::StyleProperty> m_custom_properties;
RefPtr<DOMTokenList> m_class_list;