From e347d6bdb852ecaf024ee4b655e4d084971503ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sat, 2 May 2020 20:23:05 +0200 Subject: [PATCH] LibGUI: Properly remove auto-destroyed child windows from reified_windows. I just spotted this while I saw you writing this code :-) --- Libraries/LibGUI/Window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/LibGUI/Window.cpp b/Libraries/LibGUI/Window.cpp index 1e7b4069d6..e0b791cab9 100644 --- a/Libraries/LibGUI/Window.cpp +++ b/Libraries/LibGUI/Window.cpp @@ -128,6 +128,7 @@ Window* Window::find_parent_window() void Window::server_did_destroy() { + reified_windows->remove(m_window_id); m_window_id = 0; m_visible = false; m_pending_paint_event_rects.clear(); @@ -140,7 +141,6 @@ void Window::hide() { if (!is_visible()) return; - reified_windows->remove(m_window_id); auto response = WindowServerConnection::the().send_sync(m_window_id); server_did_destroy();