RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:48:11 +00:00
Code Issues Activity Actions

Browser+WebContent: Fix HTML injection in console functions output

Browse source
This commit is contained in:
Linus Groh 2021-04-18 17:27:00 +02:00
parent a178255a8b
commit e37421bddc
2 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Applications/Browser/BrowserConsoleClient.cpp
View file

@ -37,7 +37,7 @@ namespace Browser {
JS::Value BrowserConsoleClient::log()
{
m_console_widget.print_html(vm().join_arguments());
m_console_widget.print_html(escape_html_entities(vm().join_arguments()));
return JS::js_undefined();
}
@ -46,7 +46,7 @@ JS::Value BrowserConsoleClient::info()
StringBuilder html;
html.append("<span class=\"info\">");
html.append("(i) ");
html.append(vm().join_arguments());
html.append(escape_html_entities(vm().join_arguments()));
html.append("</span>");
m_console_widget.print_html(html.string_view());
return JS::js_undefined();
@ -57,7 +57,7 @@ JS::Value BrowserConsoleClient::debug()
StringBuilder html;
html.append("<span class=\"debug\">");
html.append("(d) ");
html.append(vm().join_arguments());
html.append(escape_html_entities(vm().join_arguments()));
html.append("</span>");
m_console_widget.print_html(html.string_view());
return JS::js_undefined();
@ -68,7 +68,7 @@ JS::Value BrowserConsoleClient::warn()
StringBuilder html;
html.append("<span class=\"warn\">");
html.append("(w) ");
html.append(vm().join_arguments());
html.append(escape_html_entities(vm().join_arguments()));
html.append("</span>");
m_console_widget.print_html(html.string_view());
return JS::js_undefined();
@ -79,7 +79,7 @@ JS::Value BrowserConsoleClient::error()
StringBuilder html;
html.append("<span class=\"error\">");
html.append("(e) ");
html.append(vm().join_arguments());
html.append(escape_html_entities(vm().join_arguments()));
html.append("</span>");
m_console_widget.print_html(html.string_view());
return JS::js_undefined();
@ -94,7 +94,7 @@ JS::Value BrowserConsoleClient::clear()
JS::Value BrowserConsoleClient::trace()
{
StringBuilder html;
html.append(vm().join_arguments());
html.append(escape_html_entities(vm().join_arguments()));
auto trace = get_trace();
for (auto& function_name : trace) {
if (function_name.is_empty())