RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:17:36 +00:00
Code Issues Activity Actions

LibWeb: Move type derivation of CSS::Length into seperate function

Browse source 
That way this can (and will) be used in other places.
This commit is contained in:
Tobias Christiansen 2021-06-11 21:43:06 +02:00 • committed by Ali Mohammad Pur
parent 7a4c8e0b76
commit e3b68039bf
1 changed files with 83 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

125
Userland/Libraries/LibWeb/CSS/Parser/DeprecatedCSSParser.cpp
View file

@ -146,66 +146,107 @@ static Optional<float> try_parse_float(const StringView& string)
return is_negative ? -value : value; return is_negative ? -value : value;
} }
static CSS::Length::Type length_type_from_unit(const StringView& view)
{
if (view.ends_with('%'))
return CSS::Length::Type::Percentage;
if (view.ends_with("px", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Px;
if (view.ends_with("pt", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Pt;
if (view.ends_with("pc", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Pc;
if (view.ends_with("mm", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Mm;
if (view.ends_with("rem", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Rem;
if (view.ends_with("em", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Em;
if (view.ends_with("ex", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Ex;
if (view.ends_with("vw", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Vw;
if (view.ends_with("vh", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Vh;
if (view.ends_with("vmax", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Vmax;
if (view.ends_with("vmin", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Vmin;
if (view.ends_with("cm", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Cm;
if (view.ends_with("in", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::In;
if (view.ends_with("Q", CaseSensitivity::CaseInsensitive))
return CSS::Length::Type::Q;
if (view == "0")
return CSS::Length::Type::Px;
return CSS::Length::Type::Undefined;
}
static CSS::Length parse_length(const CSS::DeprecatedParsingContext& context, const StringView& view, bool& is_bad_length) static CSS::Length parse_length(const CSS::DeprecatedParsingContext& context, const StringView& view, bool& is_bad_length)
{ {
CSS::Length::Type type = CSS::Length::Type::Undefined; CSS::Length::Type type = length_type_from_unit(view);
Optional<float> value; Optional<float> value;
if (view.ends_with('%')) { switch (type) {
type = CSS::Length::Type::Percentage; case CSS::Length::Type::Percentage:
value = try_parse_float(view.substring_view(0, view.length() - 1)); value = try_parse_float(view.substring_view(0, view.length() - 1));
} else if (view.ends_with("px", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Px; case CSS::Length::Type::Px:
if (view == "0")
value = 0;
else
value = try_parse_float(view.substring_view(0, view.length() - 2));
break;
case CSS::Length::Type::Pt:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("pt", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Pt; case CSS::Length::Type::Pc:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("pc", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Pc; case CSS::Length::Type::Mm:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("mm", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Mm; case CSS::Length::Type::Rem:
value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("rem", CaseSensitivity::CaseInsensitive)) {
type = CSS::Length::Type::Rem;
value = try_parse_float(view.substring_view(0, view.length() - 3)); value = try_parse_float(view.substring_view(0, view.length() - 3));
} else if (view.ends_with("em", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Em; case CSS::Length::Type::Em:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("ex", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Ex; case CSS::Length::Type::Ex:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("vw", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Vw; case CSS::Length::Type::Vw:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("vh", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Vh; case CSS::Length::Type::Vh:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("vmax", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Vmax; case CSS::Length::Type::Vmax:
value = try_parse_float(view.substring_view(0, view.length() - 4)); value = try_parse_float(view.substring_view(0, view.length() - 4));
} else if (view.ends_with("vmin", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Vmin; case CSS::Length::Type::Vmin:
value = try_parse_float(view.substring_view(0, view.length() - 4)); value = try_parse_float(view.substring_view(0, view.length() - 4));
} else if (view.ends_with("cm", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Cm; case CSS::Length::Type::Cm:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("in", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::In; case CSS::Length::Type::In:
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.ends_with("Q", CaseSensitivity::CaseInsensitive)) { break;
type = CSS::Length::Type::Q; case CSS::Length::Type::Q:
value = try_parse_float(view.substring_view(0, view.length() - 1)); value = try_parse_float(view.substring_view(0, view.length() - 1));
} else if (view == "0") { break;
type = CSS::Length::Type::Px; default:
value = 0; if (context.in_quirks_mode()) {
} else if (context.in_quirks_mode()) { type = CSS::Length::Type::Px;
type = CSS::Length::Type::Px; value = try_parse_float(view);
value = try_parse_float(view); } else {
} else { value = try_parse_float(view);
value = try_parse_float(view); if (value.has_value())
if (value.has_value()) is_bad_length = true;
is_bad_length = true; }
} }
if (!value.has_value()) if (!value.has_value())