RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:37:36 +00:00
Code Issues Activity Actions

LibWeb: Let various functions throw if not enough arguments

Browse source 
...instead of handing out null / undefined / empty values.
This commit is contained in:
Linus Groh 2020-05-21 00:55:01 +01:00 • committed by Andreas Kling
parent 2d503b20da
commit e3e9749d88
3 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/Bindings/EventTargetWrapper.cpp
View file

@ -27,6 +27,7 @@
#include <AK/FlyString.h>
#include <AK/Function.h>
#include <LibJS/Interpreter.h>
#include <LibJS/Runtime/Error.h>
#include <LibJS/Runtime/Function.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibWeb/Bindings/EventListenerWrapper.h>
@ -54,7 +55,7 @@ JS::Value EventTargetWrapper::add_event_listener(JS::Interpreter& interpreter)
if (!this_object)
return {};
if (interpreter.argument_count() < 2)
return JS::js_undefined();
return interpreter.throw_exception<JS::TypeError>("addEventListener() needs two arguments");
auto event_name = interpreter.argument(0).to_string(interpreter);
if (interpreter.exception())
return {};