From e4b7ce33248a415fde8b970c7724c826d475113a Mon Sep 17 00:00:00 2001 From: Daniel Bertalan Date: Mon, 11 Apr 2022 00:16:26 +0200 Subject: [PATCH] UserspaceEmulator: Use boolean operators instead of bitwise ones Fixes a bitwise-instead-of-logical warning from Clang 14. --- Userland/DevTools/UserspaceEmulator/SoftCPU.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Userland/DevTools/UserspaceEmulator/SoftCPU.h b/Userland/DevTools/UserspaceEmulator/SoftCPU.h index 0a0a600754..b2cfe4ab82 100644 --- a/Userland/DevTools/UserspaceEmulator/SoftCPU.h +++ b/Userland/DevTools/UserspaceEmulator/SoftCPU.h @@ -418,9 +418,9 @@ public: case 5: return !zf(); // NE, NZ case 6: - return (cf() | zf()); // BE, NA + return cf() || zf(); // BE, NA case 7: - return !(cf() | zf()); // NBE, A + return !(cf() || zf()); // NBE, A case 8: return sf(); // S case 9: @@ -430,13 +430,13 @@ public: case 11: return !pf(); // NP, PO case 12: - return sf() ^ of(); // L, NGE + return sf() != of(); // L, NGE case 13: - return !(sf() ^ of()); // NL, GE + return sf() == of(); // NL, GE case 14: - return (sf() ^ of()) | zf(); // LE, NG + return (sf() != of()) || zf(); // LE, NG case 15: - return !((sf() ^ of()) | zf()); // NLE, G + return !((sf() != of()) || zf()); // NLE, G default: VERIFY_NOT_REACHED(); }