RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:37:43 +00:00
Code Issues Activity Actions

LibGUI: Stop lying about string types

Browse source
This commit is contained in:
Hendiadyoin1 2023-06-11 19:44:53 +02:00 • committed by Jelle Raaijmakers
parent a45682dcdc
commit e4f627f299
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/CommonActions.cpp
View file

@ -22,7 +22,7 @@ NonnullRefPtr<Action> make_about_action(DeprecatedString const& app_name, Icon c
auto weak_parent = AK::make_weak_ptr_if_nonnull<Window>(parent); auto weak_parent = AK::make_weak_ptr_if_nonnull<Window>(parent);
auto action = Action::create(DeprecatedString::formatted("&About {}", app_name), app_icon.bitmap_for_size(16), [=](auto&) { auto action = Action::create(DeprecatedString::formatted("&About {}", app_name), app_icon.bitmap_for_size(16), [=](auto&) {
AboutDialog::show( AboutDialog::show(
String::from_utf8(app_name).release_value_but_fixme_should_propagate_errors(), String::from_deprecated_string(app_name).release_value_but_fixme_should_propagate_errors(),
Core::Version::read_long_version_string().release_value_but_fixme_should_propagate_errors(), Core::Version::read_long_version_string().release_value_but_fixme_should_propagate_errors(),
app_icon.bitmap_for_size(32), app_icon.bitmap_for_size(32),
weak_parent) weak_parent)

4
Userland/Libraries/LibGUI/Statusbar.cpp
View file

@ -84,7 +84,7 @@ void Statusbar::update_segment(size_t index)
if (!text(i).is_empty()) if (!text(i).is_empty())
m_segments[i]->set_visible(true); m_segments[i]->set_visible(true);
} }
segment->set_text(String::from_utf8(segment->restored_text()).release_value_but_fixme_should_propagate_errors()); segment->set_text(String::from_deprecated_string(segment->restored_text()).release_value_but_fixme_should_propagate_errors());
segment->set_frame_style(Gfx::FrameStyle::SunkenPanel); segment->set_frame_style(Gfx::FrameStyle::SunkenPanel);
if (segment->mode() != Segment::Mode::Proportional) if (segment->mode() != Segment::Mode::Proportional)
segment->set_fixed_width(segment->restored_width()); segment->set_fixed_width(segment->restored_width());
@ -93,7 +93,7 @@ void Statusbar::update_segment(size_t index)
if (!m_segments[i]->is_clickable()) if (!m_segments[i]->is_clickable())
m_segments[i]->set_visible(false); m_segments[i]->set_visible(false);
} }
segment->set_text(String::from_utf8(segment->override_text()).release_value_but_fixme_should_propagate_errors()); segment->set_text(String::from_deprecated_string(segment->override_text()).release_value_but_fixme_should_propagate_errors());
segment->set_frame_style(Gfx::FrameStyle::NoFrame); segment->set_frame_style(Gfx::FrameStyle::NoFrame);
if (segment->mode() != Segment::Mode::Proportional) if (segment->mode() != Segment::Mode::Proportional)
segment->set_fixed_width(SpecialDimension::Grow); segment->set_fixed_width(SpecialDimension::Grow);