RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:07:35 +00:00
Code Issues Activity Actions

LibWeb: Port AttributeNames to FlyString

Browse source
This commit is contained in:
Shannon Booth 2023-10-08 11:42:00 +13:00 • committed by Tim Flynn
parent 6a3f27509f
commit e4f8c59210
93 changed files with 148 additions and 149 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Services/WebContent/WebDriverConnection.cpp
View file

@ -1064,18 +1064,16 @@ Messages::WebDriverClient::GetElementAttributeResponse WebDriverConnection::get_
// 4. Let result be the result of the first matching condition:
Optional<DeprecatedString> result;
auto deprecated_name = name.to_deprecated_string();
// -> If name is a boolean attribute
if (Web::HTML::is_boolean_attribute(deprecated_name)) {
if (Web::HTML::is_boolean_attribute(name)) {
// "true" (string) if the element has the attribute, otherwise null.
if (element->has_attribute(deprecated_name))
if (element->has_attribute(name))
result = "true"sv;
}
// -> Otherwise
else {
// The result of getting an attribute by name name.
result = element->deprecated_get_attribute(deprecated_name);
result = element->deprecated_get_attribute(name);
}
// 5. Return success with data result.