RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:57:35 +00:00
Code Issues Activity Actions

LibJS: Update incorrect spec comment in ToRelativeTemporalObject

Browse source 
This is a normative change in the Temporal spec.

See: 4cb192d
This commit is contained in:
Linus Groh 2022-03-29 22:56:03 +01:00
parent c637795888
commit e4fe60b972
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp
View file

@ -666,9 +666,7 @@ ThrowCompletionOr<Value> to_relative_temporal_object(GlobalObject& global_object
// f. If timeZoneName is not undefined, then
if (time_zone_name.has_value()) {
// i. If ParseText(StringToCodePoints(timeZoneName), TimeZoneNumericUTCOffset) is not a List of errors, then
// FIXME: Logic error in the spec (check for no errors -> check for errors).
// See: https://github.com/tc39/proposal-temporal/pull/2000
// i. If ParseText(StringToCodePoints(timeZoneName), TimeZoneNumericUTCOffset) is a List of errors, then
if (!is_valid_time_zone_numeric_utc_offset_syntax(*time_zone_name)) {
// 1. If ! IsValidTimeZoneName(timeZoneName) is false, throw a RangeError exception.
if (!is_valid_time_zone_name(*time_zone_name))