RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

HexEditor: Add ASCII to the value inspector

Browse source 
This is kind of redundant but probably easier to read than the ASCII
column. Also, it seems appropriate after we add other character
encodings.
This commit is contained in:
kleines Filmröllchen 2022-04-12 18:59:23 +02:00 • committed by Linus Groh
parent da7a8a8711
commit e5736cdf2f
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/HexEditor/HexEditorWidget.cpp
View file

@ -285,9 +285,11 @@ void HexEditorWidget::update_inspector_values(size_t position)
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::SignedByte, String::number(static_cast<i8>(unsigned_byte_value)));
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::UnsignedByte, String::number(unsigned_byte_value));
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::ASCII, String::formatted("{:c}", static_cast<char>(unsigned_byte_value)));
} else {
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::SignedByte, "");
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::UnsignedByte, "");
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::ASCII, "");
}
if (byte_read_count >= 2) {

4
Userland/Applications/HexEditor/ValueInspectorModel.h
View file

@ -26,6 +26,7 @@ public:
UnsignedLong,
Float,
Double,
ASCII,
__Count
};
@ -90,6 +91,8 @@ public:
return "Float";
case Double:
return "Double";
case ASCII:
return "ASCII";
default:
return "";
}
@ -112,6 +115,7 @@ public:
switch (selected_type) {
case SignedByte:
case UnsignedByte:
case ASCII:
return 1;
case SignedShort:
case UnsignedShort: