RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2026-01-12 23:11:00 +00:00
Code Issues Activity Actions

LibJS: Consistently make prototype the last argument in Object ctors

Browse source 
This is so that we can reliably allocate them in a template function,
e.g. in ordinary_create_from_constructor():

    global_object.heap().allocate<T>(
        global_object, forward<Args>(args)..., *prototype);

The majority of objects already take the prototype as the last argument,
so I updated the ones that didn't.
This commit is contained in:
Linus Groh 2021-06-19 23:21:08 +01:00 • committed by Andreas Kling
parent df095afbcc
commit e5753443ae
18 changed files with 26 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/DataView.h
View file

@ -18,7 +18,7 @@ class DataView : public Object {
public:
static DataView* create(GlobalObject&, ArrayBuffer*, size_t byte_length, size_t byte_offset);
explicit DataView(Object& prototype, ArrayBuffer*, size_t byte_length, size_t byte_offset);
explicit DataView(ArrayBuffer*, size_t byte_length, size_t byte_offset, Object& prototype);
virtual ~DataView() override;
ArrayBuffer* viewed_array_buffer() const { return m_viewed_array_buffer; }