RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:57:45 +00:00
Code Issues Activity Actions

LibJS: Consistently make prototype the last argument in Object ctors

Browse source 
This is so that we can reliably allocate them in a template function,
e.g. in ordinary_create_from_constructor():

    global_object.heap().allocate<T>(
        global_object, forward<Args>(args)..., *prototype);

The majority of objects already take the prototype as the last argument,
so I updated the ones that didn't.
This commit is contained in:
Linus Groh 2021-06-19 23:21:08 +01:00 • committed by Andreas Kling
parent df095afbcc
commit e5753443ae
18 changed files with 26 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Function.cpp
View file

@ -12,11 +12,11 @@
namespace JS {
Function::Function(Object& prototype)
: Function(prototype, {}, {})
: Function({}, {}, prototype)
{
}
Function::Function(Object& prototype, Value bound_this, Vector<Value> bound_arguments)
Function::Function(Value bound_this, Vector<Value> bound_arguments, Object& prototype)
: Object(prototype)
, m_bound_this(bound_this)
, m_bound_arguments(move(bound_arguments))