RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:27:45 +00:00
Code Issues Activity Actions

LibJS: Consistently make prototype the last argument in Object ctors

Browse source 
This is so that we can reliably allocate them in a template function,
e.g. in ordinary_create_from_constructor():

    global_object.heap().allocate<T>(
        global_object, forward<Args>(args)..., *prototype);

The majority of objects already take the prototype as the last argument,
so I updated the ones that didn't.
This commit is contained in:
Linus Groh 2021-06-19 23:21:08 +01:00 • committed by Andreas Kling
parent df095afbcc
commit e5753443ae
18 changed files with 26 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/StringIterator.cpp
View file

@ -12,10 +12,10 @@ namespace JS {
StringIterator* StringIterator::create(GlobalObject& global_object, String string)
{
return global_object.heap().allocate<StringIterator>(global_object, *global_object.string_iterator_prototype(), move(string));
return global_object.heap().allocate<StringIterator>(global_object, move(string), *global_object.string_iterator_prototype());
}
StringIterator::StringIterator(Object& prototype, String string)
StringIterator::StringIterator(String string, Object& prototype)
: Object(prototype)
, m_string(move(string))
, m_iterator(Utf8View(m_string).begin())