RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:48:11 +00:00
Code Issues Activity Actions

LibWeb: Port HTMLAnchorElement interface from DeprecatedString to String

Browse source
This commit is contained in:
Shannon Booth 2023-09-03 16:15:27 +12:00 • committed by Tim Flynn
parent 76af9d434c
commit e5910a4593
3 changed files with 21 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.cpp
View file

@ -105,32 +105,37 @@ Optional<ARIA::Role> HTMLAnchorElement::default_role() const
} }
// https://html.spec.whatwg.org/multipage/text-level-semantics.html#dom-a-text // https://html.spec.whatwg.org/multipage/text-level-semantics.html#dom-a-text
DeprecatedString HTMLAnchorElement::text() const String HTMLAnchorElement::text() const
{ {
// The text attribute's getter must return this element's descendant text content. // The text attribute's getter must return this element's descendant text content.
return descendant_text_content(); return MUST(String::from_deprecated_string(descendant_text_content()));
} }
// https://html.spec.whatwg.org/multipage/text-level-semantics.html#dom-a-text // https://html.spec.whatwg.org/multipage/text-level-semantics.html#dom-a-text
void HTMLAnchorElement::set_text(DeprecatedString const& text) void HTMLAnchorElement::set_text(String const& text)
{ {
// The text attribute's setter must string replace all with the given value within this element. // The text attribute's setter must string replace all with the given value within this element.
string_replace_all(text); string_replace_all(text.to_deprecated_string());
} }
// https://html.spec.whatwg.org/multipage/text-level-semantics.html#dom-a-referrerpolicy // https://html.spec.whatwg.org/multipage/text-level-semantics.html#dom-a-referrerpolicy
DeprecatedString HTMLAnchorElement::referrer_policy() const StringView HTMLAnchorElement::referrer_policy() const
{ {
// FIXME: This should probably be `Reflect` in the IDL.
// The IDL attribute referrerPolicy must reflect the referrerpolicy content attribute, limited to only known values. // The IDL attribute referrerPolicy must reflect the referrerpolicy content attribute, limited to only known values.
auto policy_string = deprecated_attribute(HTML::AttributeNames::referrerpolicy); auto maybe_policy_string = attribute(HTML::AttributeNames::referrerpolicy);
auto maybe_policy = ReferrerPolicy::from_string(policy_string); if (!maybe_policy_string.has_value())
if (maybe_policy.has_value()) return ""sv;
return ReferrerPolicy::to_string(maybe_policy.value());
return ""; auto maybe_policy = ReferrerPolicy::from_string(maybe_policy_string.value());
if (!maybe_policy.has_value())
return ""sv;
return ReferrerPolicy::to_string(maybe_policy.value());
} }
// https://html.spec.whatwg.org/multipage/text-level-semantics.html#dom-a-referrerpolicy // https://html.spec.whatwg.org/multipage/text-level-semantics.html#dom-a-referrerpolicy
WebIDL::ExceptionOr<void> HTMLAnchorElement::set_referrer_policy(DeprecatedString const& referrer_policy) WebIDL::ExceptionOr<void> HTMLAnchorElement::set_referrer_policy(String const& referrer_policy)
{ {
// The IDL attribute referrerPolicy must reflect the referrerpolicy content attribute, limited to only known values. // The IDL attribute referrerPolicy must reflect the referrerpolicy content attribute, limited to only known values.
return set_attribute(HTML::AttributeNames::referrerpolicy, referrer_policy); return set_attribute(HTML::AttributeNames::referrerpolicy, referrer_policy);

8
Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.h
View file

@ -23,11 +23,11 @@ public:
DeprecatedString target() const { return deprecated_attribute(HTML::AttributeNames::target); } DeprecatedString target() const { return deprecated_attribute(HTML::AttributeNames::target); }
DeprecatedString download() const { return deprecated_attribute(HTML::AttributeNames::download); } DeprecatedString download() const { return deprecated_attribute(HTML::AttributeNames::download); }
DeprecatedString text() const; String text() const;
void set_text(DeprecatedString const&); void set_text(String const&);
DeprecatedString referrer_policy() const; StringView referrer_policy() const;
WebIDL::ExceptionOr<void> set_referrer_policy(DeprecatedString const&); WebIDL::ExceptionOr<void> set_referrer_policy(String const&);
// ^EventTarget // ^EventTarget
// https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-a-element // https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-a-element

2
Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.idl
View file

@ -2,7 +2,7 @@
#import <HTML/HTMLHyperlinkElementUtils.idl> #import <HTML/HTMLHyperlinkElementUtils.idl>
// https://html.spec.whatwg.org/multipage/text-level-semantics.html#htmlanchorelement // https://html.spec.whatwg.org/multipage/text-level-semantics.html#htmlanchorelement
[Exposed=Window, UseDeprecatedAKString] [Exposed=Window]
interface HTMLAnchorElement : HTMLElement { interface HTMLAnchorElement : HTMLElement {
[HTMLConstructor] constructor(); [HTMLConstructor] constructor();